airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fokko Driesprong (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (AIRFLOW-1841) GoogleCloudStorageDownloadOperator filename parameter
Date Mon, 27 Nov 2017 07:06:00 GMT

     [ https://issues.apache.org/jira/browse/AIRFLOW-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Fokko Driesprong closed AIRFLOW-1841.
-------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.9.1

> GoogleCloudStorageDownloadOperator filename parameter
> -----------------------------------------------------
>
>                 Key: AIRFLOW-1841
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1841
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: contrib, gcp, operators
>    Affects Versions: 1.8.0, 1.9.0
>            Reporter: Igors Vaitkus
>            Assignee: Igors Vaitkus
>            Priority: Trivial
>              Labels: documentation
>             Fix For: 1.9.1
>
>
> https://github.com/apache/incubator-airflow/blob/v1-8-stable/airflow/contrib/operators/gcs_download_operator.py
> Documentation - "... If false, the downloaded data will not be stored on the local file
system."
> But filename type is a string in the documentation, it should be a union of String and
Bool, but better change it to None. And change Hook as well to None because all it does just
check the presence of a value in the parameter.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message