Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A0E1A200D26 for ; Fri, 20 Oct 2017 20:45:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9F676160BED; Fri, 20 Oct 2017 18:45:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E46AB1609ED for ; Fri, 20 Oct 2017 20:45:03 +0200 (CEST) Received: (qmail 43817 invoked by uid 500); 20 Oct 2017 18:45:03 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 43808 invoked by uid 99); 20 Oct 2017 18:45:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Oct 2017 18:45:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D5F2E1A11E0 for ; Fri, 20 Oct 2017 18:45:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id XFhKYLdHUdIh for ; Fri, 20 Oct 2017 18:45:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 6629E5FD33 for ; Fri, 20 Oct 2017 18:45:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E8342E0E80 for ; Fri, 20 Oct 2017 18:45:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 9BFF124360 for ; Fri, 20 Oct 2017 18:45:00 +0000 (UTC) Date: Fri, 20 Oct 2017 18:45:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AIRFLOW-1741) Task Duration shows two charts on first page load. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 20 Oct 2017 18:45:04 -0000 [ https://issues.apache.org/jira/browse/AIRFLOW-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213037#comment-16213037 ] ASF subversion and git services commented on AIRFLOW-1741: ---------------------------------------------------------- Commit 3d4feb60906a4e4edbd1dba4b397db1a0b5be8ed in incubator-airflow's branch refs/heads/master from [~ashb] [ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=3d4feb6 ] [AIRFLOW-1741] Correctly hide second chart on task duration page A timing/load order bug meant that this ".trigger" call was happening too early, resulting in a trigger being sent before the hook callback had been registered, meaning we didn't hide the second chart correctly on page load. Closes #2711 from ashb/AIRFLOW-1741-task-duration- charts-load > Task Duration shows two charts on first page load. > -------------------------------------------------- > > Key: AIRFLOW-1741 > URL: https://issues.apache.org/jira/browse/AIRFLOW-1741 > Project: Apache Airflow > Issue Type: Bug > Components: ui > Affects Versions: 1.8.0 > Reporter: Ash Berlin-Taylor > Assignee: Ash Berlin-Taylor > Priority: Minor > Fix For: 1.9.0 > > > As reported in AIRFLOW-930 > > When you first load the page, two charts are shown: Cumulative and Non-cumulative. However, when you toggle the "Cumulative Duration" button, one of the charts disappears, and you can now only switch between the two. > This is because of an issue with the the chart code running a trigger too early - before the trigger callback has been registered. -- This message was sent by Atlassian JIRA (v6.4.14#64029)