Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 45B90200D19 for ; Fri, 6 Oct 2017 19:47:42 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 43DCF1609E1; Fri, 6 Oct 2017 17:47:42 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8A4F21609D0 for ; Fri, 6 Oct 2017 19:47:41 +0200 (CEST) Received: (qmail 70787 invoked by uid 500); 6 Oct 2017 17:47:40 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 70778 invoked by uid 99); 6 Oct 2017 17:47:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Oct 2017 17:47:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 060491A4067 for ; Fri, 6 Oct 2017 17:47:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.222 X-Spam-Level: X-Spam-Status: No, score=-4.222 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id cT4vZwtrEteM for ; Fri, 6 Oct 2017 17:47:39 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id DCEA75FD10 for ; Fri, 6 Oct 2017 17:47:38 +0000 (UTC) Received: (qmail 70674 invoked by uid 99); 6 Oct 2017 17:47:38 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Oct 2017 17:47:38 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 4B66CF5CA4; Fri, 6 Oct 2017 17:47:38 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: criccomini@apache.org To: commits@airflow.incubator.apache.org Message-Id: <88c61fae4d9642a4a07bf120d69d6950@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: incubator-airflow git commit: [AIRFLOW-1690] Add detail to gcs error messages Date: Fri, 6 Oct 2017 17:47:38 +0000 (UTC) archived-at: Fri, 06 Oct 2017 17:47:42 -0000 Repository: incubator-airflow Updated Branches: refs/heads/v1-9-test 0080f0fcc -> 5fb5cd10d [AIRFLOW-1690] Add detail to gcs error messages Provide the system error detail in the log message. Closes #2670 from wrp/master Project: http://git-wip-us.apache.org/repos/asf/incubator-airflow/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-airflow/commit/5fb5cd10 Tree: http://git-wip-us.apache.org/repos/asf/incubator-airflow/tree/5fb5cd10 Diff: http://git-wip-us.apache.org/repos/asf/incubator-airflow/diff/5fb5cd10 Branch: refs/heads/v1-9-test Commit: 5fb5cd10d3ae6760775b74f14e2f17d8b4ceac44 Parents: 0080f0f Author: William Pursell Authored: Fri Oct 6 10:46:42 2017 -0700 Committer: Chris Riccomini Committed: Fri Oct 6 10:47:32 2017 -0700 ---------------------------------------------------------------------- airflow/utils/log/gcs_task_handler.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-airflow/blob/5fb5cd10/airflow/utils/log/gcs_task_handler.py ---------------------------------------------------------------------- diff --git a/airflow/utils/log/gcs_task_handler.py b/airflow/utils/log/gcs_task_handler.py index bb40e11..c11e7ad 100644 --- a/airflow/utils/log/gcs_task_handler.py +++ b/airflow/utils/log/gcs_task_handler.py @@ -167,8 +167,8 @@ class GCSTaskHandler(FileTaskHandler, LoggingMixin): # closed). tmpfile.flush() self.hook.upload(bkt, blob, tmpfile.name) - except: - self.log.error('Could not write logs to %s', remote_log_location) + except Exception as e: + self.log.error('Could not write logs to %s: %s', remote_log_location, e) def parse_gcs_url(self, gsurl): """