airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-1323) Operators related to Dataproc should keep some parameters consistent
Date Tue, 03 Oct 2017 09:16:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189434#comment-16189434
] 

ASF subversion and git services commented on AIRFLOW-1323:
----------------------------------------------------------

Commit ed248d0d2994aa05ae8fc0681bdc0ceccd4e367e in incubator-airflow's branch refs/heads/v1-9-test
from [~cjqian]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=ed248d0 ]

[AIRFLOW-1323] Made Dataproc operator parameter names consistent

Closes #2636 from cjqian/1323

(cherry picked from commit dd861f8cd0491f977ba545415d667f3d4611b5b8)
Signed-off-by: Bolke de Bruin <bolke@xs4all.nl>


> Operators related to Dataproc should keep some parameters consistent
> --------------------------------------------------------------------
>
>                 Key: AIRFLOW-1323
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1323
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: operators
>            Reporter: Yu Ishikawa
>            Assignee: Crystal Qian
>            Priority: Minor
>
> The parameters of {{DataprocClusterDeleteOperator}} and {{DataprocClusterCreateOperator}}
for GCP connection ID are {{google_cloud_conn_id}}.  On the other hand, for example,
>  {{DataProcPigOperator}}'s paramter is {{gcp_conn_id}}. I think this inconsistency may
make users confused. We should keep the parameter's name consistent.
> For another example, parameters for a cluster name don't have consistency like {{cluster_name}}
and {{dataproc_cluster}}.
> - https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/operators/dataproc_operator.py#L58
> - https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/operators/dataproc_operator.py#L626



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message