Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@airflow.incubator.apache.org
Date: Fri, 22 Sep 2017 19:44:01 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: commits@airflow.incubator.apache.org
Message-ID: <JIRA.13103726.1505941099000.179293.1506109441698@Atlassian.JIRA>
In-Reply-To: <JIRA.13103726.1505941099000@Atlassian.JIRA>
References: <JIRA.13103726.1505941099000@Atlassian.JIRA> <JIRA.13103726.1505941099128@jira-lw-us.apache.org>
Subject: [jira] [Commented] (AIRFLOW-1627) SubDagOperator initialization
 should only query pools when necessary
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 22 Sep 2017 19:44:08 -0000


    [ https://issues.apache.org/jira/browse/AIRFLOW-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176995#comment-16176995 ] 

ASF subversion and git services commented on AIRFLOW-1627:
----------------------------------------------------------

Commit 516ace82c4ce3517196973829c06a396336b823c in incubator-airflow's branch refs/heads/v1-9-test from [~dxhuang]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=516ace8 ]

[AIRFLOW-1627] Only query pool in SubDAG init when necessary

When checking for pool conflicts in a SubDAG, ensure that a task in
the SubDAG is actually in the same pool as the SubDagOperator itself
to avoid querying the database unnecessarily.

Closes #2620 from dhuang/AIRFLOW-1627


> SubDagOperator initialization should only query pools when necessary
> --------------------------------------------------------------------
>
>                 Key: AIRFLOW-1627
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1627
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: operators, subdag
>            Reporter: Daniel Huang
>            Assignee: Daniel Huang
>            Priority: Minor
>             Fix For: 1.9.0
>
>
> If a SubDagOperator is assigned to a pool, it queries db for pool info to ensure there is no pool conflict with one of its tasks when only 1 slot remains. However, we should check that there's a possible conflict (a task in the subdag is in the same pool as the subdag) before actually querying for pools.
> I have a DAG with hundreds of subdags and I found that the pool conflict check was taking up a fair chunk of time when processing the DAG file.
> Relevant code: https://github.com/apache/incubator-airflow/blob/a81c153cc48e4c99a9e0a5047990b84c5d07e3cb/airflow/operators/subdag_operator.py#L60-L81


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)