airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Riccomini (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (AIRFLOW-1627) SubDagOperator initialization should only query pools when necessary
Date Fri, 22 Sep 2017 19:42:00 GMT

     [ https://issues.apache.org/jira/browse/AIRFLOW-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Riccomini resolved AIRFLOW-1627.
--------------------------------------
    Resolution: Fixed

Issue resolved by pull request #2620
[https://github.com/apache/incubator-airflow/pull/2620]

> SubDagOperator initialization should only query pools when necessary
> --------------------------------------------------------------------
>
>                 Key: AIRFLOW-1627
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1627
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: operators, subdag
>            Reporter: Daniel Huang
>            Assignee: Daniel Huang
>            Priority: Minor
>             Fix For: 1.9.0
>
>
> If a SubDagOperator is assigned to a pool, it queries db for pool info to ensure there
is no pool conflict with one of its tasks when only 1 slot remains. However, we should check
that there's a possible conflict (a task in the subdag is in the same pool as the subdag)
before actually querying for pools.
> I have a DAG with hundreds of subdags and I found that the pool conflict check was taking
up a fair chunk of time when processing the DAG file.
> Relevant code: https://github.com/apache/incubator-airflow/blob/a81c153cc48e4c99a9e0a5047990b84c5d07e3cb/airflow/operators/subdag_operator.py#L60-L81



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message