Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@airflow.incubator.apache.org
Date: Tue, 29 Aug 2017 09:36:00 +0000 (UTC)
From: "Shintaro Murakami (JIRA)" <jira@apache.org>
To: commits@airflow.incubator.apache.org
Message-ID: <JIRA.13081281.1498007085000.144644.1503999360200@Atlassian.JIRA>
In-Reply-To: <JIRA.13081281.1498007085000@Atlassian.JIRA>
References: <JIRA.13081281.1498007085000@Atlassian.JIRA> <JIRA.13081281.1498007085487@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (AIRFLOW-1330) Connection.parse_from_uri
 doesn't work for google_cloud_platform and so on
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 29 Aug 2017 09:36:05 -0000


    [ https://issues.apache.org/jira/browse/AIRFLOW-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144995#comment-16144995 ] 

Shintaro Murakami edited comment on AIRFLOW-1330 at 8/29/17 9:35 AM:
---------------------------------------------------------------------

It would be better to drop {{conn_url}}, or specify either only one of {{conn_url}} or other new arguments. If we set both {{conn_url}} and other new arguments, it's confusing as to which one takes precedence.
After deciding which plan to go with, I will fix this PR([https://github.com/apache/incubator-airflow/pull/2525]).


was (Author: mrkm4ntr):
It would be better to drop {{--conn_url}}, or specify either only one of {{--conn_url}} or other new arguments. If we set both {{--conn_url}} and other new arguments, it's confusing as to which one takes precedence.
After deciding which plan to go with, I will fix this PR([https://github.com/apache/incubator-airflow/pull/2525]).

> Connection.parse_from_uri doesn't work for google_cloud_platform and so on
> --------------------------------------------------------------------------
>
>                 Key: AIRFLOW-1330
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1330
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: cli
>            Reporter: Yu Ishikawa
>
> h2. Overview
> {{Connection.parse_from_uri}} doesn't work for some types like {{google_cloud_platform}} whose type name includes under scores. Since `urllib.parse.urlparse()` which is used in {{Connection.parse_from_url}} doesn't support a schema name which include under scores.
> So, airflow's CLI doesn't work when a given connection URI includes under scores like {{google_cloud_platform://XXXXX}}.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)