Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 46D24166F70 for ; Tue, 22 Aug 2017 15:41:05 +0200 (CEST) Received: (qmail 62169 invoked by uid 500); 22 Aug 2017 13:41:04 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 62150 invoked by uid 99); 22 Aug 2017 13:41:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Aug 2017 13:41:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8CBAEC2F8E for ; Tue, 22 Aug 2017 13:41:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id gAiXjyvxm9RL for ; Tue, 22 Aug 2017 13:41:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5545361181 for ; Tue, 22 Aug 2017 13:41:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 15277E041C for ; Tue, 22 Aug 2017 13:41:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 984C32538F for ; Tue, 22 Aug 2017 13:41:00 +0000 (UTC) Date: Tue, 22 Aug 2017 13:41:00 +0000 (UTC) From: "Ash Berlin-Taylor (JIRA)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AIRFLOW-1177) variable json deserialize does not work at set defaults MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AIRFLOW-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136809#comment-16136809 ] Ash Berlin-Taylor commented on AIRFLOW-1177: -------------------------------------------- I think this issue is larger than just JSON -- {{setdefault}} will die with a similar error if the object already exists! > variable json deserialize does not work at set defaults > ------------------------------------------------------- > > Key: AIRFLOW-1177 > URL: https://issues.apache.org/jira/browse/AIRFLOW-1177 > Project: Apache Airflow > Issue Type: Bug > Components: models > Affects Versions: Airflow 1.8 > Reporter: barak schoster > Assignee: barak schoster > > at line: > https://github.com/apache/incubator-airflow/blob/master/airflow/models.py#L3685 > obj has no attribute val, it is the val itself. > it will throw error like: > Variable.setdefault("some_key", deserialize_json=True,default=json.dumps(default_dag_variables)) > File "/usr/local/lib/python2.7/site-packages/airflow/models.py", line 3586, in setdefault > return json.loads(obj.val) > AttributeError: 'unicode' object has no attribute 'val' -- This message was sent by Atlassian JIRA (v6.4.14#64029)