airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ace Haidrey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-1508) Skipped state not part of State.task_states
Date Tue, 29 Aug 2017 23:13:01 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146311#comment-16146311
] 

Ace Haidrey commented on AIRFLOW-1508:
--------------------------------------

Agreed that currently it is not a big deal, but I still do think it's a potential bug source
in the future, because SKIPPED is a task state. I was wondering why would it be bad if it
was added in the payload? Seems like it's safe and doesn't hurt/ is more complete (just my
thoughts). 

Yes our use case is at Pandora, we've built some infrastructure around Airflow and a plugin
that is a BluePrint to collect stats on our instances (we deploy an instance per team), and
then use a tool called Consul + Prometheus to monitor. So we want the metrics of all the different
task states. 

It's not huge but currently have to have our looping like:
{code}
for task_state_type in State.task_states + (State.SKIPPED, ):
{code}
And I'm just hoping if future states get added we'd also pick up (being a part of task_states)
on those rather than having to go see the code ourselves.

Also appreciate the response [~erod] :)

> Skipped state not part of State.task_states
> -------------------------------------------
>
>                 Key: AIRFLOW-1508
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1508
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Ace Haidrey
>            Assignee: Ace Haidrey
>
> In the airflow.state module, [State.task_state|https://github.com/apache/incubator-airflow/blob/master/airflow/utils/state.py#L44]
doesn't include the {{SKIPPED}} state even though the {{TaskInstance}} object has it. I was
wondering if this was on purpose or a bug. I would think it should be part of the task_state
object since that makes sense and will help some of my workflows to not have to add this in
manually. 
> I'm not sure who the appropriate person to ask is so thinking I'll tag some people and
get some feedback (hopefully that's okay)..
> CC [~criccomini] [~bolke] [~allisonwang]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message