airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-1483) Page size on model views is to large to render quickly
Date Tue, 15 Aug 2017 22:02:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127943#comment-16127943
] 

ASF subversion and git services commented on AIRFLOW-1483:
----------------------------------------------------------

Commit 04bfba3aa97deab850c14763279d33a6dfceb205 in incubator-airflow's branch refs/heads/master
from [~erod]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=04bfba3 ]

[AIRFLOW-1483] Making page size consistent in list

Views showing model listings had large page sizes
which made page
loading really slow client-side, mostly due to DOM
processing and
JS plugin rendering.
Also, the page size was inconsistent across some
listings.

This commit introduces a configurable page size,
and by default
it'll use a page_size = 100. Also, the same page
size is applied to
all the model views controlled by flask_admin to
be consistent.

Closes #2497 from edgarRd/erod-ui-page-size-conf


> Page size on model views is to large to render quickly
> ------------------------------------------------------
>
>                 Key: AIRFLOW-1483
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1483
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Edgar Rodriguez
>            Assignee: Edgar Rodriguez
>         Attachments: taskinstance_page_loading_breakdown.png
>
>
> The current hardcoded values for the {{page_size}} on {{AirflowModelView}} is set to
{{500}} rows, which is usually too large to render in less than 1-2 secs in modern browsers.

> Also, in some endpoints it is also taking a long time to render server-side the HTML
content for 500 rows, taking around 1-2 secs (on the server) or sometimes more.
> Simple approach is to reduce this value to something more sensible (50 maybe?). Probably
making it a configurable value would be a good option too in case the default is not good
enough.
> See attachment for a profiled sample of a page loading time.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message