Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@airflow.incubator.apache.org
Date: Fri, 21 Jul 2017 18:49:00 +0000 (UTC)
From: "Trevor Edwards (JIRA)" <jira@apache.org>
To: commits@airflow.incubator.apache.org
Message-ID: <JIRA.13089126.1500662896000.304478.1500662940147@Atlassian.JIRA>
In-Reply-To: <JIRA.13089126.1500662896000@Atlassian.JIRA>
References: <JIRA.13089126.1500662896000@Atlassian.JIRA> <JIRA.13089126.1500662896960@jira-lw-us.apache.org>
Subject: [jira] [Updated] (AIRFLOW-1441) Tutorial Inconsistencies Between
 Example Pipeline Definition and Recap
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 21 Jul 2017 18:49:05 -0000


     [ https://issues.apache.org/jira/browse/AIRFLOW-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trevor Edwards updated AIRFLOW-1441:
------------------------------------
    Description: 
In the tutorial page, the first view of the code titled "Pipeline Definition" is slightly inconsistent from the Recap, though presumably both should be the same code:

1. The initial view says:

{code}
Code that goes along with the Airflow tutorial located at:
https://github.com/airbnb/airflow/blob/master/airflow/example_dags/tutorial.py
{code}

While the recap says:

{code}
Code that goes along with the Airflow located at:
http://airflow.readthedocs.org/en/latest/tutorial.html
{code}

The first has a more informative first line while the second has a more accurate link. Therefore, it would make sense to change both to:

{code}
Code that goes along with the Airflow tutorial located at:
http://airflow.readthedocs.org/en/latest/tutorial.html
{code}

2. The initial view has the line:

{code}
dag = DAG('tutorial', default_args=default_args)
{code}

While the recap has:
{code}
dag = DAG(
    'tutorial', default_args=default_args, schedule_interval=timedelta(1))
{code}

Since the schedule_interval is described in the tutorial, it seems the recap version should be kept here.

  was:
In the tutorial page, the first view of the code titled "Pipeline Definition" is slightly inconsistent from the Recap, though presumably both should be the same code:

1. The initial view says:

{code:python}
Code that goes along with the Airflow tutorial located at:
https://github.com/airbnb/airflow/blob/master/airflow/example_dags/tutorial.py
{code}

While the recap says:

{code:python}
Code that goes along with the Airflow located at:
http://airflow.readthedocs.org/en/latest/tutorial.html
{code}

The first has a more informative first line while the second has a more accurate link. Therefore, it would make sense to change both to:

{code:python}
Code that goes along with the Airflow tutorial located at:
http://airflow.readthedocs.org/en/latest/tutorial.html
{code}

2. The initial view has the line:

{code:python}
dag = DAG('tutorial', default_args=default_args)
{code}

While the recap has:
{code:python}
dag = DAG(
    'tutorial', default_args=default_args, schedule_interval=timedelta(1))
{code}

Since the schedule_interval is described in the tutorial, it seems the recap version should be kept here.


> Tutorial Inconsistencies Between Example Pipeline Definition and Recap
> ----------------------------------------------------------------------
>
>                 Key: AIRFLOW-1441
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1441
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Trevor Edwards
>            Priority: Minor
>
> In the tutorial page, the first view of the code titled "Pipeline Definition" is slightly inconsistent from the Recap, though presumably both should be the same code:
> 1. The initial view says:
> {code}
> Code that goes along with the Airflow tutorial located at:
> https://github.com/airbnb/airflow/blob/master/airflow/example_dags/tutorial.py
> {code}
> While the recap says:
> {code}
> Code that goes along with the Airflow located at:
> http://airflow.readthedocs.org/en/latest/tutorial.html
> {code}
> The first has a more informative first line while the second has a more accurate link. Therefore, it would make sense to change both to:
> {code}
> Code that goes along with the Airflow tutorial located at:
> http://airflow.readthedocs.org/en/latest/tutorial.html
> {code}
> 2. The initial view has the line:
> {code}
> dag = DAG('tutorial', default_args=default_args)
> {code}
> While the recap has:
> {code}
> dag = DAG(
>     'tutorial', default_args=default_args, schedule_interval=timedelta(1))
> {code}
> Since the schedule_interval is described in the tutorial, it seems the recap version should be kept here.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)