airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-1294) Backfills can loose tasks to execute due to tasks setting themselves to NONE
Date Tue, 13 Jun 2017 15:22:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-1294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048011#comment-16048011
] 

ASF subversion and git services commented on AIRFLOW-1294:
----------------------------------------------------------

Commit 6e3bcd31868ac834e1d8a9305e66ee1b8c586eb1 in incubator-airflow's branch refs/heads/master
from [~bolke]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=6e3bcd3 ]

[AIRFLOW-1294] Backfills can loose tasks to execute

In backfills we can loose tasks to execute due to
a task
setting its own state to NONE if concurrency
limits are reached,
this makes them fall outside of the scope the
backfill is
managing hence they will not be executed.

Dear Airflow maintainers,

Please accept this PR. I understand that it will
not be reviewed until I have checked off all the
steps below!

### JIRA
- [X] My PR addresses the following [Airflow JIRA]
(https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For
example, "[AIRFLOW-XXX] My Airflow PR"
    -
https://issues.apache.org/jira/browse/AIRFLOW-1294

### Description
- [X] Here are some details about my PR, including
screenshots of any UI changes:

In backfills we can loose tasks to execute due to
a task
setting its own state to NONE if concurrency
limits are reached,
this makes them fall outside of the scope the
backfill is
managing hence they will not be executed.

### Tests
- [X] My PR adds the following unit tests __OR__
does not need testing for this extremely good
reason:
Should be covered by current tests, will adjust if
required.

### Commits
- [X] My commits all reference JIRA issues in
their subject lines, and I have squashed multiple
commits if they address the same issue. In
addition, my commits follow the guidelines from
"[How to write a good git commit
message](http://chris.beams.io/posts/git-
commit/)":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not
"adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

mistercrunch aoen saguziel This is a simplified
fix that should be easier to digest in 1.8.2. It
does not address all underlying issues as in
https://github.com/apache/incubator-
airflow/pull/2356 , but those can be addressed
separately and in smaller bits.

Closes #2360 from bolkedebruin/fix_race_backfill_2


> Backfills can loose tasks to execute due to tasks setting themselves to NONE
> ----------------------------------------------------------------------------
>
>                 Key: AIRFLOW-1294
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1294
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: backfill
>    Affects Versions: 1.8.1
>            Reporter: Bolke de Bruin
>            Priority: Blocker
>             Fix For: 1.8.2
>
>
> In the backfills we can loose tasks to execute due to a task setting its own state to
NONE if concurrency limits are reached, this makes them fall outside of the scope the backfill
is managing hence they will not be executed. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message