airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-1274) HttpSensor parameter params is overriding BaseOperator params and should be renamed
Date Sat, 03 Jun 2017 00:45:04 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035712#comment-16035712
] 

ASF subversion and git services commented on AIRFLOW-1274:
----------------------------------------------------------

Commit f1ff09d07b344126a0a0698dad755f330b1f28d3 in incubator-airflow's branch refs/heads/master
from [~alice_berard]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=f1ff09d ]

[AIRFLOW-1274][HTTPSENSOR] Rename parameter params to data

Renamed the parameter `params` to `request_params` in `HttpSensor` as it
was conflicting with `BaseOperator` `params` and causing failed DAGs
parsing.

Closes #2342 from aliceabe/master


> HttpSensor parameter params is overriding BaseOperator params and should be renamed
> -----------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-1274
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1274
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Alice Berard
>            Assignee: Alice Berard
>
> {{HttpSensor}} parameter {{params}} is overriding BaseOperator {{params}} and should
be renamed.
> It is screwing DAG parsing:
> Traceback (most recent call last):
>   File "/usr/local/lib/python2.7/dist-packages/airflow/models.py", line 264, in process_file
>     m = imp.load_source(mod_name, filepath)
>   File "/home/alice_berard/mydags/anomaly_detection/anomaly_detection/curiosity/curiosity_dags.py",
line 14, in <module>
>     pool='curiosity',
>   File "/home/alice_berard/mydags/anomaly_detection/anomaly_detection/curiosity/dag_builder.py",
line 133, in build
>     pool=self.pool
>   File "/usr/local/lib/python2.7/dist-packages/airflow/utils/decorators.py", line 58,
in wrapper
>     dag_params.update(params)
> ValueError: dictionary update sequence element #0 has length 1; 2 is required



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message