airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-1200) Forbid creation of a variable with an empty key
Date Wed, 17 May 2017 18:54:04 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014623#comment-16014623
] 

ASF subversion and git services commented on AIRFLOW-1200:
----------------------------------------------------------

Commit 3acfa048a88342ca059afd9329e7ba4cf1af0929 in incubator-airflow's branch refs/heads/master
from [~skudriashev]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=3acfa04 ]

[AIRFLOW-1200] Forbid creation of a variable with an empty key

Closes #2299 from skudriashev/airflow-1200


> Forbid creation of a variable with an empty key
> -----------------------------------------------
>
>                 Key: AIRFLOW-1200
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1200
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ui
>    Affects Versions: Airflow 2.0
>            Reporter: Stanislav Kudriashev
>            Assignee: Stanislav Kudriashev
>             Fix For: Airflow 2.0
>
>
> This leads to the following exception:
> {code}
> Traceback (most recent call last):
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/flask/app.py",
line 2000, in __call__
>     return self.wsgi_app(environ, start_response)
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/flask/app.py",
line 1991, in wsgi_app
>     response = self.make_response(self.handle_exception(e))
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/flask/app.py",
line 1567, in handle_exception
>     reraise(exc_type, exc_value, tb)
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/flask/app.py",
line 1988, in wsgi_app
>     response = self.full_dispatch_request()
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/flask/app.py",
line 1641, in full_dispatch_request
>     rv = self.handle_user_exception(e)
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/flask/app.py",
line 1544, in handle_user_exception
>     reraise(exc_type, exc_value, tb)
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/flask/app.py",
line 1639, in full_dispatch_request
>     rv = self.dispatch_request()
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/flask/app.py",
line 1625, in dispatch_request
>     return self.view_functions[rule.endpoint](**req.view_args)
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/flask_admin/base.py",
line 69, in inner
>     return self._run_view(f, *args, **kwargs)
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/flask_admin/base.py",
line 368, in _run_view
>     return fn(self, *args, **kwargs)
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/flask_admin/model/base.py",
line 1900, in index_view
>     return_url=self._get_list_url(view_args),
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/flask_admin/base.py",
line 308, in render
>     return render_template(template, **kwargs)
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/flask/templating.py",
line 134, in render_template
>     context, ctx.app)
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/flask/templating.py",
line 116, in _render
>     rv = template.render(context)
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/jinja2/environment.py",
line 989, in render
>     return self.environment.handle_exception(exc_info, True)
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/jinja2/environment.py",
line 754, in handle_exception
>     reraise(exc_type, exc_value, tb)
>   File "/home/skudriashev/Work/incubator-airflow/airflow/www/templates/airflow/variable_list.html",
line 18, in top-level template code
>     {% extends 'admin/model/list.html' %}
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/flask_admin/templates/bootstrap3/admin/model/list.html",
line 6, in top-level template code
>     {% import 'admin/model/row_actions.html' as row_actions with context %}
>   File "/home/skudriashev/Work/incubator-airflow/airflow/www/templates/admin/master.html",
line 18, in top-level template code
>     {% extends 'admin/base.html' %}
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/flask_admin/templates/bootstrap3/admin/base.html",
line 30, in top-level template code
>     {% block page_body %}
>   File "/home/skudriashev/Work/incubator-airflow/airflow/www/templates/admin/master.html",
line 104, in block "page_body"
>     {% block body %}
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/flask_admin/templates/bootstrap3/admin/model/list.html",
line 62, in block "body"
>     {% block model_list_table %}
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/flask_admin/templates/bootstrap3/admin/model/list.html",
line 110, in block "model_list_table"
>     {% block list_row scoped %}
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/flask_admin/templates/bootstrap3/admin/model/list.html",
line 138, in block "list_row"
>     {{ get_value(row, c) }}
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/flask_admin/model/base.py",
line 1742, in get_list_value
>     self.column_type_formatters,
>   File "/home/skudriashev/Work/incubator-airflow/.venv/lib/python2.7/site-packages/flask_admin/model/base.py",
line 1707, in _get_list_value
>     value = column_fmt(self, context, model, name)
>   File "/home/skudriashev/Work/incubator-airflow/airflow/www/views.py", line 2158, in
hidden_field_formatter
>     if should_hide_value_for_key(model.key):
>   File "/home/skudriashev/Work/incubator-airflow/airflow/www/views.py", line 283, in
should_hide_value_for_key
>     return any(s in key_name for s in DEFAULT_SENSITIVE_VARIABLE_FIELDS) \
>   File "/home/skudriashev/Work/incubator-airflow/airflow/www/views.py", line 283, in
<genexpr>
>     return any(s in key_name for s in DEFAULT_SENSITIVE_VARIABLE_FIELDS) \
> TypeError: argument of type 'NoneType' is not iterable
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message