Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E47E0200C7F for ; Wed, 19 Apr 2017 05:47:45 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E154A160BA1; Wed, 19 Apr 2017 03:47:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3D7D2160BAC for ; Wed, 19 Apr 2017 05:47:45 +0200 (CEST) Received: (qmail 85671 invoked by uid 500); 19 Apr 2017 03:47:44 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 85653 invoked by uid 99); 19 Apr 2017 03:47:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Apr 2017 03:47:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C41291AA94D for ; Wed, 19 Apr 2017 03:47:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.001 X-Spam-Level: X-Spam-Status: No, score=-100.001 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id dQyhH-P6aQO5 for ; Wed, 19 Apr 2017 03:47:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B79275F1E7 for ; Wed, 19 Apr 2017 03:47:42 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 263D0E081E for ; Wed, 19 Apr 2017 03:47:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B14F521B47 for ; Wed, 19 Apr 2017 03:47:41 +0000 (UTC) Date: Wed, 19 Apr 2017 03:47:41 +0000 (UTC) From: "Kengo Seki (JIRA)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AIRFLOW-1121) airflow webserver --pid no longer write out pid file! MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 19 Apr 2017 03:47:46 -0000 [ https://issues.apache.org/jira/browse/AIRFLOW-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974013#comment-15974013 ] Kengo Seki commented on AIRFLOW-1121: ------------------------------------- Yeah, that's my fault. I mistakenly assumed that pid file is unnecessary if webserver runs in the foreground. Thanks for the notification Sid, I'll submit a PR today if possible. > airflow webserver --pid no longer write out pid file! > ----------------------------------------------------- > > Key: AIRFLOW-1121 > URL: https://issues.apache.org/jira/browse/AIRFLOW-1121 > Project: Apache Airflow > Issue Type: Bug > Components: webserver > Affects Versions: 1.8.1rc0 > Reporter: Siddharth Anand > Priority: Blocker > Fix For: 1.8.1 > > > I've run into a regression with the webserver. It looks like the --pid argument is no longer honored in 1.8.1. The pid file is not being written out! As a result, watchdog processes like monitd, which watch the processes mentioned in the pid file, keep trying to spawn webservers because the pid files are not being written. > HISTTIMEFORMAT="%d/%m/%y %T " PYTHONPATH=/usr/local/agari/ep-pipeline/production/current/analysis/cluster/:/usr/local/agari/ep-pipeline/production/current/analysis/lookups/ TMP=/data/tmp AIRFLOW_HOME=/data/airflow PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin airflow webserver -p 8080 --pid /data/airflow/pids/airflow-webserver.pid > The Patch that might have broken this is > https://github.com/apache/incubator-airflow/commit/a9b20a04 > If I include -D, things work: > airflow webserver -D --pid ~/this.pid > sid-as-mbp:~ siddharth$ ls -lrt *pid > -rw-r--r-- 1 siddharth staff 5 Apr 18 14:37 this-monitor.pid > -rw-r--r-- 1 siddharth staff 5 Apr 18 14:37 this.pid > sid-as-mbp:~ siddharth$ cat *pid > 8732 > 8735 > However, this doesn't help me as I don't want to run with -D. > cc [~sekikn] [~criccomini] -- This message was sent by Atlassian JIRA (v6.3.15#6346)