airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeeyoung Kim (JIRA)" <j...@apache.org>
Subject [jira] [Created] (AIRFLOW-1141) Remove DAG.crawl_for_tasks method
Date Mon, 24 Apr 2017 19:40:04 GMT
Jeeyoung Kim created AIRFLOW-1141:
-------------------------------------

             Summary: Remove DAG.crawl_for_tasks method
                 Key: AIRFLOW-1141
                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1141
             Project: Apache Airflow
          Issue Type: Task
            Reporter: Jeeyoung Kim
            Priority: Trivial


Currently {{DAG}} class has the method:

{noformat}
    def crawl_for_tasks(objects):
        """
        Typically called at the end of a script by passing globals() as a
        parameter. This allows to not explicitly add every single task to the
        dag explicitly.
        """
        raise NotImplementedError("")
{noformat}

which is not called or tested from anywhere. I suggest removing this method as it doesn't
do anything and there's no documentation related to it. Moreover, if one creates a subclass
of DAG, pylint returns the following warning: {{Method 'crawl_for_tasks' is abstract in class
'DAG' but is not overridden (abstract-method)}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message