airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-1121) airflow webserver --pid no longer write out pid file!
Date Thu, 20 Apr 2017 22:23:04 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977698#comment-15977698
] 

ASF subversion and git services commented on AIRFLOW-1121:
----------------------------------------------------------

Commit aef7dd0a53411f3edb2333cb36a457056e5ab652 in incubator-airflow's branch refs/heads/v1-8-test
from [~sekikn]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=aef7dd0 ]

[AIRFLOW-1121][AIRFLOW-1004] Fix `airflow webserver --pid` to write out pid file

After AIRFLOW-1004, --pid option is no longer
honored and
the pid file is not being written out. This PR
fixes it.

Closes #2249 from sekikn/AIRFLOW-1121

(cherry picked from commit 8d643897cf6171d110e7139fb31c3d4d47c3acca)


> airflow webserver --pid no longer write out pid file!
> -----------------------------------------------------
>
>                 Key: AIRFLOW-1121
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1121
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: webserver
>    Affects Versions: 1.8.1rc0
>            Reporter: Siddharth Anand
>            Assignee: Kengo Seki
>            Priority: Blocker
>             Fix For: 1.8.1
>
>
> I've run into a regression with the webserver. It looks like the --pid argument is no
longer honored in 1.8.1. The pid file is not being written out! As a result, watchdog processes
like monitd, which watch the processes mentioned in the pid file, keep trying to spawn webservers
because the pid files are not being written.
> HISTTIMEFORMAT="%d/%m/%y %T " PYTHONPATH=/usr/local/agari/ep-pipeline/production/current/analysis/cluster/:/usr/local/agari/ep-pipeline/production/current/analysis/lookups/
TMP=/data/tmp AIRFLOW_HOME=/data/airflow PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin
airflow webserver -p 8080  --pid /data/airflow/pids/airflow-webserver.pid
> The Patch that might have broken this is 
> https://github.com/apache/incubator-airflow/commit/a9b20a04
> If I include -D, things work:
> airflow webserver -D --pid ~/this.pid
> sid-as-mbp:~ siddharth$ ls -lrt *pid
> -rw-r--r--  1 siddharth  staff  5 Apr 18 14:37 this-monitor.pid
> -rw-r--r--  1 siddharth  staff  5 Apr 18 14:37 this.pid
> sid-as-mbp:~ siddharth$ cat *pid
> 8732
> 8735
> However, this doesn't help me as I don't want to run with -D. 
> cc [~sekikn] [~criccomini]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message