airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-1062) DagRun#find returns wrong result if external_trigger=False is specified
Date Tue, 04 Apr 2017 06:31:41 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954630#comment-15954630
] 

ASF subversion and git services commented on AIRFLOW-1062:
----------------------------------------------------------

Commit 010b80aa8b417091705556a07d5970fe0cc4efb2 in incubator-airflow's branch refs/heads/v1-8-test
from [~sekikn]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=010b80a ]

[AIRFLOW-1062] Fix DagRun#find to return correct result

DagRun#find returns wrong result if
external_trigger=False is specified,
because adding filter is skipped on that
condition. This PR fixes it.

Closes #2210 from sekikn/AIRFLOW-1062

(cherry picked from commit e4494f85ed5593c99949b52e1e0044c2a35f097f)
Signed-off-by: Bolke de Bruin <bolke@xs4all.nl>


> DagRun#find returns wrong result if external_trigger=False is specified
> -----------------------------------------------------------------------
>
>                 Key: AIRFLOW-1062
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1062
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: models
>            Reporter: Kengo Seki
>            Assignee: Kengo Seki
>             Fix For: 1.8.1
>
>
> Given the following record,
> {code}
> sqlite> select id, external_trigger from dag_run;
> 1|1
> sqlite>
> {code}
> the following code should return no result,
> {code}
> In [1]: from airflow import models
> In [2]: models.DagRun.find(external_trigger=False)
> {code}
> ... but an externally-triggered record is returned erroneously.
> {code}
> Out[2]: [<DagRun example_bash_operator @ 2017-04-03 01:56:15: manual__2017-04-03T01:56:15,
externally triggered: True>]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message