airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick McKenna (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (AIRFLOW-984) Subdags unrecognized when subclassing SubDagOperator
Date Tue, 14 Mar 2017 20:49:41 GMT

     [ https://issues.apache.org/jira/browse/AIRFLOW-984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Patrick McKenna updated AIRFLOW-984:
------------------------------------
    Description: 
If a user subclasses SubDagOperator, the parent DAG will not pick up the subdags:

https://github.com/apache/incubator-airflow/blob/c44e2009ee625ce4a82c50e585a3c8617d9b4ff8/airflow/models.py#L2974

which means a DagBag won't find them:

https://github.com/apache/incubator-airflow/blob/c44e2009ee625ce4a82c50e585a3c8617d9b4ff8/airflow/models.py#L311
https://github.com/apache/incubator-airflow/blob/c44e2009ee625ce4a82c50e585a3c8617d9b4ff8/airflow/models.py#L365

This PR appears to be the cause: https://github.com/apache/incubator-airflow/pull/1196/files.

  was:
If a user subclasses SubDagOperator, the parent DAG will not pick up the subdags:

https://github.com/jlowin/airflow/blob/44fcabc36048cd6e80660fc023afce85e3d435a0/airflow/models.py#L2969

which means a DagBag won't find them:

https://github.com/jlowin/airflow/blob/44fcabc36048cd6e80660fc023afce85e3d435a0/airflow/models.py#L311
https://github.com/jlowin/airflow/blob/44fcabc36048cd6e80660fc023afce85e3d435a0/airflow/models.py#L365

This PR appears to be the culprit: https://github.com/apache/incubator-airflow/pull/1196/files.


> Subdags unrecognized when subclassing SubDagOperator
> ----------------------------------------------------
>
>                 Key: AIRFLOW-984
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-984
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Patrick McKenna
>            Priority: Minor
>
> If a user subclasses SubDagOperator, the parent DAG will not pick up the subdags:
> https://github.com/apache/incubator-airflow/blob/c44e2009ee625ce4a82c50e585a3c8617d9b4ff8/airflow/models.py#L2974
> which means a DagBag won't find them:
> https://github.com/apache/incubator-airflow/blob/c44e2009ee625ce4a82c50e585a3c8617d9b4ff8/airflow/models.py#L311
> https://github.com/apache/incubator-airflow/blob/c44e2009ee625ce4a82c50e585a3c8617d9b4ff8/airflow/models.py#L365
> This PR appears to be the cause: https://github.com/apache/incubator-airflow/pull/1196/files.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message