airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Cederstrand (JIRA)" <j...@apache.org>
Subject [jira] [Created] (AIRFLOW-949) kill_process_tree does not kill the root process
Date Tue, 07 Mar 2017 14:49:37 GMT
Erik Cederstrand created AIRFLOW-949:
----------------------------------------

             Summary: kill_process_tree does not kill the root process
                 Key: AIRFLOW-949
                 URL: https://issues.apache.org/jira/browse/AIRFLOW-949
             Project: Apache Airflow
          Issue Type: Bug
          Components: utils
    Affects Versions: 1.8.0rc4
            Reporter: Erik Cederstrand
         Attachments: helpers.patch

The kill_process_tree() function in airflow/utils/helper.py does not attempt to kill the root
process. Since there's also a kill_descendant_processes() function, I assume that was the
intent.

Also, according to the comments, the intent is to send first SIGTERM, and then SIGKILL, to
decendant processes. But in fact, SIGTERM is sent twice.

The attached patch fixes both problems.

This was found while investigating why the airflow worker would not kill certain jobs that
had crashed. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message