airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-938) SQLAlchemy query in task_stats should be compatible with Postgres
Date Fri, 03 Mar 2017 21:53:45 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895087#comment-15895087
] 

ASF subversion and git services commented on AIRFLOW-938:
---------------------------------------------------------

Commit 7764c75a7c8d1cd3d4a3f9ce021d92988bb45698 in incubator-airflow's branch refs/heads/master
from [~saguziel]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=7764c75 ]

[AIRFLOW-938] Use test for True in task_stats queries

Fix a bug with the task_stats query on postgres which doesn't support
== 1.

https://issues.apache.org/jira/browse/AIRFLOW-938

I've seen the other PR but I'll try to see if this
method works because I believe `__eq__(True)` is
just `== True`, and it is how it is down here http
://docs.sqlalchemy.org/en/latest/core/sqlelement.h
tml#sqlalchemy.sql.expression.and_ (underscore is
part of link)

Closes #2123 from saguziel/aguziel-fix-task-
stats-2


> SQLAlchemy query in task_stats should be compatible with Postgres
> -----------------------------------------------------------------
>
>                 Key: AIRFLOW-938
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-938
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Alex Guziel
>            Assignee: Alex Guziel
>
> Right now, we check for truthiness by comparing to 1, which is not portable and does
not work on pgsql



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message