Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@airflow.incubator.apache.org
Date: Tue, 28 Feb 2017 22:25:45 +0000 (UTC)
From: "Bolke de Bruin (JIRA)" <jira@apache.org>
To: commits@airflow.incubator.apache.org
Message-ID: <JIRA.13046725.1488223319000.23307.1488320745470@Atlassian.JIRA>
In-Reply-To: <JIRA.13046725.1488223319000@Atlassian.JIRA>
References: <JIRA.13046725.1488223319000@Atlassian.JIRA> <JIRA.13046725.1488223319625@jira-lw-us.apache.org>
Subject: [jira] [Commented] (AIRFLOW-920) Can't mark non-existent tasks as
 successful from graph view
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 28 Feb 2017 22:25:49 -0000


    [ https://issues.apache.org/jira/browse/AIRFLOW-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888974#comment-15888974 ] 

Bolke de Bruin commented on AIRFLOW-920:
----------------------------------------

[~aoen] It does propagate in its current form: if you mark success a "subdag" operator from its parent dag it will mark success all tasks part of that subdag. My PR just verifies the tree of the dag to make sure dag runs are created for any missing subdag dag runs. I consider this to be something of a hack as it is in my opinion the wrong place to do it (the webserver).

> Can't mark non-existent tasks as successful from graph view
> -----------------------------------------------------------
>
>                 Key: AIRFLOW-920
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-920
>             Project: Apache Airflow
>          Issue Type: Sub-task
>    Affects Versions: 1.8.0rc4
>            Reporter: Dan Davydov
>            Assignee: Bolke de Bruin
>
> If you want to add a subdag operator with depends on past set to an existing dag you need to mark the subdag as successful in the UI in order for it to start running. Previously this was possible by mark-successing the non-existent task instance/dagrun in the UI via the graph view. Now when you try to mark the task successful Airflow gives an empty list of tasks that it is going to try to mark successful, probably because the task instance/dagrun do not exist.
> Repro steps:
> - Create a DAG with a dummy task
> - Let this DAG run for one dagrun
> - Add a new subdag operator that contains a dummy operator to this DAG that
> has depends_on_past set to true
> - click on the white square for the new subdag operator in the DAGs first
> dagrun
> - Click "Zoom into subdag" (takes you to the graph view for the subdag)
> - Click the dummy task in the graph view and click "Mark Success"
> - Observe that the list of tasks to mark as success is empty (it should
> contain the dummy task)
> [~bolke]


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)