Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@airflow.incubator.apache.org
Date: Mon, 13 Feb 2017 19:11:41 +0000 (UTC)
From: "Yi Chen (JIRA)" <jira@apache.org>
To: commits@airflow.incubator.apache.org
Message-ID: <JIRA.13042453.1486952446000.66006.1487013101717@Atlassian.JIRA>
In-Reply-To: <JIRA.13042453.1486952446000@Atlassian.JIRA>
References: <JIRA.13042453.1486952446000@Atlassian.JIRA> <JIRA.13042453.1486952446807@jira-lw-us.apache.org>
Subject: [jira] [Commented] (AIRFLOW-870) Airflow Web UI "Mark Success"
 action not working properly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 13 Feb 2017 19:11:50 -0000


    [ https://issues.apache.org/jira/browse/AIRFLOW-870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864239#comment-15864239 ] 

Yi Chen commented on AIRFLOW-870:
---------------------------------

i have opened a PR [https://github.com/apache/incubator-airflow/pull/2075] for issue 1. I think I need a bit more discussion on issue 2.  

> Airflow Web UI "Mark Success" action not working properly
> ---------------------------------------------------------
>
>                 Key: AIRFLOW-870
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-870
>             Project: Apache Airflow
>          Issue Type: Bug
>    Affects Versions: Airflow 1.8
>            Reporter: Yi Chen
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I have found a few issues and some ideas of resolving them:
> 1) *Issue*: In Web UI, if click Mark Success of a task that has not been processed(a.k.a any white box in list view), I get "No task instances to mark as successful" error message.
> *Reason*: A task that has not been processed has a record in the table task_instance with state column value as NULL. Then, here https://github.com/apache/incubator-airflow/blob/v1-8-stable/airflow/www/views.py#L1146 , this line filters out not only the case `TI.state = State.SUCCESS` but also the case `TI.state is NULL`. 
> *Solution*: make this line as ` or_((TI.state.is_(None)), TI.state != State.SUCCESS)).all()` 
> 2) *Issue*: Not clear why we need a new option in "Mark Success" -- the "Recursive" option. I think we used to have the option "DownStream" or "UpStream" with recursive searching. Can anyone explain the design and double check the implementation? Right now, if I do not choose "Recursive" option with the "DownStream". I get KeyError in this line https://github.com/apache/incubator-airflow/blob/v1-8-stable/airflow/www/views.py#L1188. 
> *Reason*: In this line, https://github.com/apache/incubator-airflow/blob/v1-8-stable/airflow/www/views.py#L1122 , We actually have got the relatives from recursive searching already, and the task_ids is populated, but task_id_to_dag is not populated properly if  "Recursive" option is not chosen. Therefore a KeyError show up later as mentioned above.
> *Solution*: I think we have to discuss the design of the desired behavior of each option and refactor code w.r.t.the design.
> [This is my first Apache JIRA ticket. Feel free to point out any mistakes in reporting and describing issues if I have any.]


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)