Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@airflow.incubator.apache.org
Date: Sun, 12 Feb 2017 23:11:41 +0000 (UTC)
From: "George Sakkis (JIRA)" <jira@apache.org>
To: commits@airflow.incubator.apache.org
Message-ID: <JIRA.13042386.1486897425000.59157.1486941101676@Atlassian.JIRA>
In-Reply-To: <JIRA.13042386.1486897425000@Atlassian.JIRA>
References: <JIRA.13042386.1486897425000@Atlassian.JIRA> <JIRA.13042386.1486897425861@jira-lw-us.apache.org>
Subject: [jira] [Updated] (AIRFLOW-867) Tons of unit tests are ignored
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 12 Feb 2017 23:11:45 -0000


     [ https://issues.apache.org/jira/browse/AIRFLOW-867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

George Sakkis updated AIRFLOW-867:
----------------------------------
    Priority: Major  (was: Critical)

> Tons of unit tests are ignored
> ------------------------------
>
>                 Key: AIRFLOW-867
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-867
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: tests
>            Reporter: George Sakkis
>            Assignee: George Sakkis
>
> I was poking around in tests and found out that lots of tests are not discovered by nosetests:
> {noformat}
> $ nosetests -q --collect-only 
> ----------------------------------------------------------------------
> Ran 254 tests in 0.948s
> $ grep -R 'def test' tests/ | wc -l
> 360
> {noformat}
> Initially I thought it might be related to not having installed all extra dependencies but it turns out it's because apparently nosetests expects explicit import of the related modules instead of discovering them automatically (like py.test). For example, when adding an {{from .ti_deps.deps.runnable_exec_date_dep import *}} in {{tests/__init__.py}} it finds 260 tests, while when commenting out all imports in this module it finds only 15!
> h4. Possible options
> * Quick fix: Add the necessary missing "import *" to discover all current tests.
> * Better fix: Rename all test modules to start with "test_"
>   -Move from nosetests to py.test and get rid of the ugly error-prone 'import *' hack.-


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)