airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davy...@apache.org
Subject incubator-airflow git commit: [AIRFLOW-906] Update Code icon from lightning bolt to file
Date Fri, 24 Feb 2017 23:00:54 GMT
Repository: incubator-airflow
Updated Branches:
  refs/heads/master ffec38109 -> bc4720071


[AIRFLOW-906] Update Code icon from lightning bolt to file

Lightning bolts are not a visual metaphor for code
or files. Since Glyphicon doesn't have a code icon
(<>, for instance), we should use its file icon.

Dear Airflow Maintainers,

Please accept this PR that addresses the following
issues:
AIRFLOW-906

Testing Done:
None.

Before/After screenshots in AIRFLOW-906 (https://i
ssues.apache.org/jira/browse/AIRFLOW-906)

Update Code icon from lightning bolt to file

Lightning bolts are not a visual metaphor for code
or files. Since Glyphicon doesn't have a code icon
(<>, for instance), we should use its file icon.

Merge pull request #1 from djarratt/djarratt-
patch-1

Update Code icon from lightning bolt to file

AIRFLOW-906 change glyphicon flash to file

Merge pull request #2 from djarratt/djarratt-
patch-2

AIRFLOW-906 change glyphicon flash to file

Closes #2104 from djarratt/master


Project: http://git-wip-us.apache.org/repos/asf/incubator-airflow/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-airflow/commit/bc472007
Tree: http://git-wip-us.apache.org/repos/asf/incubator-airflow/tree/bc472007
Diff: http://git-wip-us.apache.org/repos/asf/incubator-airflow/diff/bc472007

Branch: refs/heads/master
Commit: bc47200711be4d2c0b36b772651dae4f5e01a204
Parents: ffec381
Author: Dan Jarratt <djarratt@users.noreply.github.com>
Authored: Fri Feb 24 15:00:51 2017 -0800
Committer: Dan Davydov <dan.davydov@airbnb.com>
Committed: Fri Feb 24 15:00:51 2017 -0800

----------------------------------------------------------------------
 airflow/www/static/bootstrap-theme.css       | 2 +-
 airflow/www/templates/airflow/dag.html       | 2 +-
 airflow/www/templates/airflow/dags.html      | 2 +-
 airflow/www/templates/airflow/list_dags.html | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-airflow/blob/bc472007/airflow/www/static/bootstrap-theme.css
----------------------------------------------------------------------
diff --git a/airflow/www/static/bootstrap-theme.css b/airflow/www/static/bootstrap-theme.css
index 5b126ae..734f940 100644
--- a/airflow/www/static/bootstrap-theme.css
+++ b/airflow/www/static/bootstrap-theme.css
@@ -3068,7 +3068,7 @@ tbody.collapse.in {
 .glyphicon-log-in:before {
   content: "\e161";
 }
-.glyphicon-flash:before {
+.glyphicon-file:before {
   content: "\e162";
 }
 .glyphicon-log-out:before {

http://git-wip-us.apache.org/repos/asf/incubator-airflow/blob/bc472007/airflow/www/templates/airflow/dag.html
----------------------------------------------------------------------
diff --git a/airflow/www/templates/airflow/dag.html b/airflow/www/templates/airflow/dag.html
index 43fe8c5..e5a305c 100644
--- a/airflow/www/templates/airflow/dag.html
+++ b/airflow/www/templates/airflow/dag.html
@@ -90,7 +90,7 @@
       </li>
       <li>
         <a href="{{ url_for("airflow.code", dag_id=dag.dag_id, root=root) }}">
-          <span class="glyphicon glyphicon-flash" aria-hidden="true"></span>
+          <span class="glyphicon glyphicon-file" aria-hidden="true"></span>
           Code
         </a>
       </li>

http://git-wip-us.apache.org/repos/asf/incubator-airflow/blob/bc472007/airflow/www/templates/airflow/dags.html
----------------------------------------------------------------------
diff --git a/airflow/www/templates/airflow/dags.html b/airflow/www/templates/airflow/dags.html
index 1b97c85..379f153 100644
--- a/airflow/www/templates/airflow/dags.html
+++ b/airflow/www/templates/airflow/dags.html
@@ -167,7 +167,7 @@
 
                 <!-- Code -->
                 <a href="{{ url_for("airflow.code", dag_id=dag.dag_id) }}" title="Code
View">
-                    <span class="glyphicon glyphicon-flash" aria-hidden="true"></span>
+                    <span class="glyphicon glyphicon-file" aria-hidden="true"></span>
                 </a>
 
                 <!-- Logs -->

http://git-wip-us.apache.org/repos/asf/incubator-airflow/blob/bc472007/airflow/www/templates/airflow/list_dags.html
----------------------------------------------------------------------
diff --git a/airflow/www/templates/airflow/list_dags.html b/airflow/www/templates/airflow/list_dags.html
index 2ad9416..9ace2fd 100644
--- a/airflow/www/templates/airflow/list_dags.html
+++ b/airflow/www/templates/airflow/list_dags.html
@@ -167,7 +167,7 @@
                 <i class="icon-align-left"></i>
               </a>
               <a href="{{ url_for("airflow.code", dag_id=row.dag_id) }}" title="Code View">
-                <span class="glyphicon glyphicon-flash" aria-hidden="true"></span>
+                <span class="glyphicon glyphicon-file" aria-hidden="true"></span>
               </a>
               <a href="{{ url_for("airflow.refresh", dag_id=row.dag_id) }}" title="Refresh">
                 <span class="glyphicon glyphicon-refresh" aria-hidden="true"></span>


Mime
View raw message