airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-906) Update Code icon from lightning bolt to file
Date Fri, 24 Feb 2017 23:01:44 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883698#comment-15883698
] 

ASF subversion and git services commented on AIRFLOW-906:
---------------------------------------------------------

Commit bc47200711be4d2c0b36b772651dae4f5e01a204 in incubator-airflow's branch refs/heads/master
from [~djarratt]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=bc47200 ]

[AIRFLOW-906] Update Code icon from lightning bolt to file

Lightning bolts are not a visual metaphor for code
or files. Since Glyphicon doesn't have a code icon
(<>, for instance), we should use its file icon.

Dear Airflow Maintainers,

Please accept this PR that addresses the following
issues:
AIRFLOW-906

Testing Done:
None.

Before/After screenshots in AIRFLOW-906 (https://i
ssues.apache.org/jira/browse/AIRFLOW-906)

Update Code icon from lightning bolt to file

Lightning bolts are not a visual metaphor for code
or files. Since Glyphicon doesn't have a code icon
(<>, for instance), we should use its file icon.

Merge pull request #1 from djarratt/djarratt-
patch-1

Update Code icon from lightning bolt to file

AIRFLOW-906 change glyphicon flash to file

Merge pull request #2 from djarratt/djarratt-
patch-2

AIRFLOW-906 change glyphicon flash to file

Closes #2104 from djarratt/master


> Update Code icon from lightning bolt to file
> --------------------------------------------
>
>                 Key: AIRFLOW-906
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-906
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: webapp
>            Reporter: Dan Jarratt
>            Priority: Minor
>         Attachments: airflow-current-flash-icon.png, airflow-suggested-file-icon.png
>
>
> Lightning bolts are not a visual metaphor for code or files. Since Glyphicon doesn't
have a code icon (<>, for instance), we should use its file icon.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message