airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "George Sakkis (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (AIRFLOW-787) Avoid unnecessary closing and reopening a session if not sleeping
Date Sun, 22 Jan 2017 12:53:27 GMT

     [ https://issues.apache.org/jira/browse/AIRFLOW-787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

George Sakkis resolved AIRFLOW-787.
-----------------------------------
    Resolution: Invalid

I missed the fact that the session is already closed at https://github.com/apache/incubator-airflow/blob/master/airflow/jobs.py#L160
so there's no real room for improvement here (except for potentially a small refactoring to
remove the second redundant {{session.close()}})

> Avoid unnecessary closing and reopening a session if not sleeping
> -----------------------------------------------------------------
>
>                 Key: AIRFLOW-787
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-787
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: scheduler
>            Reporter: George Sakkis
>            Priority: Minor
>
> At https://github.com/apache/incubator-airflow/blob/master/airflow/jobs.py#L173 the current
session is closed even if {{sleep_for}} is zero.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message