airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-780) The UI no longer shows broken DAGs
Date Fri, 27 Jan 2017 09:31:24 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15842441#comment-15842441
] 

ASF subversion and git services commented on AIRFLOW-780:
---------------------------------------------------------

Commit 67cbb966410226c1489bb730af3af45330fc51b9 in incubator-airflow's branch refs/heads/master
from [~aoen]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=67cbb96 ]

[AIRFLOW-780] Fix dag import errors no longer working

The import errors were no longer working after the
multiprocessor update
(since they are cleared after each DAG directory
is parsed). This change
fixes them, and adds tests to prevent future
regressions.

Also fix a couple of linter errors.

Note that there are a few inefficiencies (e.g.
sometimes we delete then add import errors in the
same place instead of just doing an update), but
this is equivalent to the old behavior.

Testing Done:
- Added missing unit tests for dag imports. Note
that some of them strangely fail for python 3 and
it became too time consuming to debug since I
don't have a copy of the travis environment, I
even ran with the same version of python locally
and couldn't reproduce. I have skipped those 3
tests in python 3 for now.

Closes #2018 from aoen/fix_parse_errors_not_displa


> The UI no longer shows broken DAGs
> ----------------------------------
>
>                 Key: AIRFLOW-780
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-780
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Dan Davydov
>            Assignee: Dan Davydov
>            Priority: Critical
>             Fix For: 1.8.1
>
>
> When a faulty dag is placed in the dags folder the UI would report a parsing error. Now
it doesn’t due to the separate parising (but not reporting back errors)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message