airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-739) test_pickle_info has an error message on travis while pickling
Date Fri, 20 Jan 2017 15:44:27 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831982#comment-15831982
] 

ASF subversion and git services commented on AIRFLOW-739:
---------------------------------------------------------

Commit 08e28ab889dee158dd8ed6d2dab6a5016e293ce5 in incubator-airflow's branch refs/heads/v1-8-test
from [~bolke]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=08e28ab ]

[AIRFLOW-739] Set pickle_info log to debug

pickle_info tries to pickle. If it catches an
exception
it is assumed that the DAG is not pickable and
continues.
Therefore, it should log to debug instead and not
provide
a full stacktrace.

Closes #1975 from bolkedebruin/AIRFLOW-739


> test_pickle_info has an error message on travis while pickling
> --------------------------------------------------------------
>
>                 Key: AIRFLOW-739
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-739
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Bolke de Bruin
>            Priority: Critical
>
> On Travis this test logs and error message but doesn't fail the test. This is because:
> {code}
>     @provide_session
>     def pickle_info(self, session=None):
>         d = {}
>         d['is_picklable'] = True
>         try:
>             dttm = datetime.now()
>             pickled = pickle.dumps(self)
>             d['pickle_len'] = len(pickled)
>             d['pickling_duration'] = "{}".format(datetime.now() - dttm)
>         except Exception as e:
>             logging.exception(e)
>             d['is_picklable'] = False
>             d['stacktrace'] = traceback.format_exc()
>         return d
> {code}
> Logs to error, while no propagation happens and the error is non fatal. Therefore it
should log to debug instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message