Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@airflow.incubator.apache.org
Date: Thu, 24 Nov 2016 17:10:59 +0000 (UTC)
From: "Siddharth Anand (JIRA)" <jira@apache.org>
To: commits@airflow.incubator.apache.org
Message-ID: <JIRA.13023095.1479969906000.362491.1480007459049@Atlassian.JIRA>
In-Reply-To: <JIRA.13023095.1479969906000@Atlassian.JIRA>
References: <JIRA.13023095.1479969906000@Atlassian.JIRA> <JIRA.13023095.1479969906342@arcas>
Subject: [jira] [Issue Comment Deleted] (AIRFLOW-652) Endpoint
 /admin/airflow/sandbox seems unnecessary
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 24 Nov 2016 17:11:03 -0000


     [ https://issues.apache.org/jira/browse/AIRFLOW-652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Siddharth Anand updated AIRFLOW-652:
------------------------------------
    Comment: was deleted

(was: [~g.toonstra] I wonder if the sandbox (it if can be made to work) can be used for your http operator test!)

> Endpoint /admin/airflow/sandbox seems unnecessary
> -------------------------------------------------
>
>                 Key: AIRFLOW-652
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-652
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: webserver
>            Reporter: Kengo Seki
>            Priority: Minor
>
> airflow/www/views.py exposes an endpoint /sandbox as follows:
> {code}
>  627     @expose('/sandbox')
>  628     @login_required
>  629     def sandbox(self):
>  630         title = "Sandbox Suggested Configuration"
>  631         cfg_loc = conf.AIRFLOW_CONFIG + '.sandbox'
>  632         f = open(cfg_loc, 'r')
>  633         config = f.read()
>  634         f.close()
>  635         code_html = Markup(highlight(
>  636             config,
>  637             lexers.IniLexer(),  # Lexer call
>  638             HtmlFormatter(noclasses=True))
>  639         )
>  640         return self.render(
>  641             'airflow/code.html',
>  642             code_html=code_html, title=title, subtitle=cfg_loc)
> {code}
> But this endpoint seems unused. If there is no airflow.cfg.sandbox file, "Ooops" page is shown. I think we can remove this for code cleanup.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)