airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From criccom...@apache.org
Subject incubator-airflow git commit: [AIRFLOW-658] Improve schema_update_options in GCP
Date Tue, 29 Nov 2016 21:59:32 GMT
Repository: incubator-airflow
Updated Branches:
  refs/heads/master d9bba86e9 -> 209e7e9fa


[AIRFLOW-658] Improve schema_update_options in GCP

Default argument for `schema_update_options` needs
to be immutable.
Changed to an empty tuple instead of an empty
list.

Closes #1909 from Jalepeno112/bug/AIRFLOW-658


Project: http://git-wip-us.apache.org/repos/asf/incubator-airflow/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-airflow/commit/209e7e9f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-airflow/tree/209e7e9f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-airflow/diff/209e7e9f

Branch: refs/heads/master
Commit: 209e7e9fabfe0ad6423020874c583d56ffe899ba
Parents: d9bba86
Author: Giovanni Briggs <gbriggs2012@gmail.com>
Authored: Tue Nov 29 13:59:17 2016 -0800
Committer: Chris Riccomini <chrisr@wepay.com>
Committed: Tue Nov 29 13:59:17 2016 -0800

----------------------------------------------------------------------
 airflow/contrib/hooks/bigquery_hook.py | 2 +-
 airflow/contrib/operators/gcs_to_bq.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-airflow/blob/209e7e9f/airflow/contrib/hooks/bigquery_hook.py
----------------------------------------------------------------------
diff --git a/airflow/contrib/hooks/bigquery_hook.py b/airflow/contrib/hooks/bigquery_hook.py
index b76126a..a0cb71d 100644
--- a/airflow/contrib/hooks/bigquery_hook.py
+++ b/airflow/contrib/hooks/bigquery_hook.py
@@ -342,7 +342,7 @@ class BigQueryBaseCursor(object):
                  skip_leading_rows=0,
                  write_disposition='WRITE_EMPTY',
                  field_delimiter=',',
-                 schema_update_options=[]):
+                 schema_update_options=()):
         """
         Executes a BigQuery load command to load data from Google Cloud Storage
         to BigQuery. See here:

http://git-wip-us.apache.org/repos/asf/incubator-airflow/blob/209e7e9f/airflow/contrib/operators/gcs_to_bq.py
----------------------------------------------------------------------
diff --git a/airflow/contrib/operators/gcs_to_bq.py b/airflow/contrib/operators/gcs_to_bq.py
index 26d996a..c2f0c79 100644
--- a/airflow/contrib/operators/gcs_to_bq.py
+++ b/airflow/contrib/operators/gcs_to_bq.py
@@ -46,7 +46,7 @@ class GoogleCloudStorageToBigQueryOperator(BaseOperator):
         bigquery_conn_id='bigquery_default',
         google_cloud_storage_conn_id='google_cloud_storage_default',
         delegate_to=None,
-        schema_update_options=[],
+        schema_update_options=(),
         *args,
         **kwargs):
         """


Mime
View raw message