Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@airflow.incubator.apache.org
Date: Sat, 1 Oct 2016 07:34:20 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: commits@airflow.incubator.apache.org
Message-ID: <JIRA.13008151.1475047706000.714499.1475307260472@Atlassian.JIRA>
In-Reply-To: <JIRA.13008151.1475047706000@Atlassian.JIRA>
References: <JIRA.13008151.1475047706000@Atlassian.JIRA> <JIRA.13008151.1475047706334@arcas>
Subject: [jira] [Commented] (AIRFLOW-530) Update docs to reflect connection
 environment var has to be in uppercase
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 01 Oct 2016 07:34:25 -0000


    [ https://issues.apache.org/jira/browse/AIRFLOW-530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15538097#comment-15538097 ] 

ASF subversion and git services commented on AIRFLOW-530:
---------------------------------------------------------

Commit c02425d4839b557ad27c328886fb9367c013b1fb in incubator-airflow's branch refs/heads/master from [~daniel@memrise.com]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=c02425d ]

[AIRFLOW-530] Update docs to reflect connection environment var has to be in uppercase

Dear Airflow Maintainers,

Please accept this PR that addresses the following
issues:
https://issues.apache.org/jira/browse/AIRFLOW-530

Right now, the documentation does not clearly
state that connection names are converted to
uppercase form when searched in the environment
(https://github.com/apache/incubator-airflow/blob/
master/airflow/hooks/base_hook.py#L60-L60).
This is confusing as the best practice in Airflow
seems to be to define connections in lower case
form.

Closes #1811 from danielzohar/connection_env_var


> Update docs to reflect connection environment var has to be in uppercase
> ------------------------------------------------------------------------
>
>                 Key: AIRFLOW-530
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-530
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Daniel Zohar
>            Assignee: Daniel Zohar
>            Priority: Minor
>
> Right now, the documentation does not clearly state that connection names are converted to uppercase form when searched in the environment (https://github.com/apache/incubator-airflow/blob/master/airflow/hooks/base_hook.py#L60-L60). 
> This is confusing as the best practice in Airflow seems to be to define connections in lower case form.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)