Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@airflow.incubator.apache.org
Date: Sun, 2 Oct 2016 06:44:20 +0000 (UTC)
From: "Siddharth Anand (JIRA)" <jira@apache.org>
To: commits@airflow.incubator.apache.org
Message-ID: <JIRA.12989285.1468453726000.717216.1475390660616@Atlassian.JIRA>
In-Reply-To: <JIRA.12989285.1468453726000@Atlassian.JIRA>
References: <JIRA.12989285.1468453726000@Atlassian.JIRA> <JIRA.12989285.1468453726033@arcas>
Subject: [jira] [Resolved] (AIRFLOW-333) Plugins containing objects without
 __name__ are broken
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 02 Oct 2016 06:44:25 -0000


     [ https://issues.apache.org/jira/browse/AIRFLOW-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Siddharth Anand resolved AIRFLOW-333.
-------------------------------------
    Resolution: Fixed

Issue resolved by pull request #1738
[https://github.com/apache/incubator-airflow/pull/1738]

> Plugins containing objects without __name__ are broken
> ------------------------------------------------------
>
>                 Key: AIRFLOW-333
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-333
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: core, plugins
>    Affects Versions: Airflow 1.8
>            Reporter: George Leslie-Waksman
>            Assignee: George Leslie-Waksman
>
> Using the sample plugin from the documentation: https://pythonhosted.org/airflow/plugins.html
> And running against master, results in:
> {noformat}
> [2016-07-13 16:35:01,662] {__init__.py:50} INFO - Using executor SequentialExecutor
> Traceback (most recent call last):
>   File "/Users/waksman/.pyenv/versions/3.5.1/bin/airflow", line 17, in <module>
>     from airflow import configuration
>   File "/Users/waksman/.pyenv/versions/3.5.1/lib/python3.5/site-packages/airflow/__init__.py", line 82, in <module>
>     operators._integrate_plugins()
>   File "/Users/waksman/.pyenv/versions/3.5.1/lib/python3.5/site-packages/airflow/operators/__init__.py", line 103, in _integrate_plugins
>     from airflow.plugins_manager import operators as _operators
>   File "/Users/waksman/.pyenv/versions/3.5.1/lib/python3.5/site-packages/airflow/plugins_manager.py", line 109, in <module>
>     make_module('airflow.www.admin_views' + p.name, p.admin_views))
>   File "/Users/waksman/.pyenv/versions/3.5.1/lib/python3.5/site-packages/airflow/plugins_manager.py", line 97, in make_module
>     module.__dict__.update((o.__name__, o) for o in objects)
>   File "/Users/waksman/.pyenv/versions/3.5.1/lib/python3.5/site-packages/airflow/plugins_manager.py", line 97, in <genexpr>
>     module.__dict__.update((o.__name__, o) for o in objects)
> AttributeError: 'TestView' object has no attribute '__name__'
> {noformat}
> The issue seems to be because of: https://github.com/apache/incubator-airflow/blob/master/airflow/plugins_manager.py#L97
> This line requires that all objects in a plugin module have a '__name__' attribute. This works just fine for operators, hooks, and executors, which are all classes (and have a __name__) but fails for views, blueprints, and links, which are instances (and do not have __name__).
> This appears to have been introduced in https://github.com/apache/incubator-airflow/commit/851adc5547597ec51743be4bc47d634c77d6dc17


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)