airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From criccom...@apache.org
Subject incubator-airflow git commit: [AIRFLOW-587] Fix incorrect scope for Google Auth[]
Date Mon, 24 Oct 2016 14:48:35 GMT
Repository: incubator-airflow
Updated Branches:
  refs/heads/master c65f403a5 -> 928fa986c


[AIRFLOW-587] Fix incorrect scope for Google Auth[]

The requested scope is incorrect when calling the
Googe API. This
splits the scope defines as a single script into
an array.

Closes #1850 from alexvanboxel/bugfix/airflow-587
-google-auth


Project: http://git-wip-us.apache.org/repos/asf/incubator-airflow/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-airflow/commit/928fa986
Tree: http://git-wip-us.apache.org/repos/asf/incubator-airflow/tree/928fa986
Diff: http://git-wip-us.apache.org/repos/asf/incubator-airflow/diff/928fa986

Branch: refs/heads/master
Commit: 928fa986c3e1509bfcaa2de4a19edac023ade87f
Parents: c65f403
Author: Alex Van Boxel <alex@vanboxel.be>
Authored: Mon Oct 24 07:48:28 2016 -0700
Committer: Chris Riccomini <chrisr@wepay.com>
Committed: Mon Oct 24 07:48:28 2016 -0700

----------------------------------------------------------------------
 airflow/contrib/auth/backends/google_auth.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-airflow/blob/928fa986/airflow/contrib/auth/backends/google_auth.py
----------------------------------------------------------------------
diff --git a/airflow/contrib/auth/backends/google_auth.py b/airflow/contrib/auth/backends/google_auth.py
index 8aed03a..70c8e13 100644
--- a/airflow/contrib/auth/backends/google_auth.py
+++ b/airflow/contrib/auth/backends/google_auth.py
@@ -90,8 +90,9 @@ class GoogleAuthBackend(object):
             'google',
             consumer_key=get_config_param('client_id'),
             consumer_secret=get_config_param('client_secret'),
-            request_token_params={'scope': '''https://www.googleapis.com/auth/userinfo.profile
-                                        https://www.googleapis.com/auth/userinfo.email'''},
+            request_token_params={'scope': [
+                'https://www.googleapis.com/auth/userinfo.profile',
+                'https://www.googleapis.com/auth/userinfo.email']},
             base_url='https://www.google.com/accounts/',
             request_token_url=None,
             access_token_method='POST',


Mime
View raw message