Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@airflow.incubator.apache.org
Date: Sun, 14 Aug 2016 02:40:21 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: commits@airflow.incubator.apache.org
Message-ID: <JIRA.12997055.1471035337000.300005.1471142421359@Atlassian.JIRA>
In-Reply-To: <JIRA.12997055.1471035337000@Atlassian.JIRA>
References: <JIRA.12997055.1471035337000@Atlassian.JIRA> <JIRA.12997055.1471035337637@arcas>
Subject: [jira] [Commented] (AIRFLOW-426) PR Tool should automatically add
 JIRA references if they appear anywhere in the PR
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Sun, 14 Aug 2016 02:40:26 -0000


    [ https://issues.apache.org/jira/browse/AIRFLOW-426?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D154=
20176#comment-15420176 ]=20

ASF subversion and git services commented on AIRFLOW-426:
---------------------------------------------------------

Commit 3767e69dd0ed6d6ea245da87b2b6297e5140cd76 in incubator-airflow's bran=
ch refs/heads/master from jlowin
[ https://git-wip-us.apache.org/repos/asf?p=3Dincubator-airflow.git;h=3D376=
7e69 ]

[AIRFLOW-423][AIRFLOW-424][AIRFLOW-426] UX updates for PR Tool

Some big UX improvements to the PR tool:

AIRFLOW-423: commit messages are automatically wrapped at 50 characters. Pa=
ragraph breaks and tab indents are preserved. The first line of the commit =
is NOT forced to be 72 characters because handling this on subsequent lines=
 is challenging. This is also deployed throughout the PR tool to make long =
status messages prettier.

https://issues.apache.org/jira/browse/AIRFLOW-423

AIRFLOW-424: this commit fixes a number of whitespace and formatting issues=
. It=E2=80=99s only contribution to functionality is that the JIRA resoluti=
on process is a little clearer.

https://issues.apache.org/jira/browse/AIRFLOW-424

AIRFLOW-426: I think this one is pretty cool. If the PR author mentions a J=
IRA issue anywhere in their PR (including on GitHub or buried in a commit),=
 then the PR tool will automatically add it to the PR title. It even catche=
s misformatted ones. So if the 20th commit mentions =E2=80=9CAIRFLOW   - -4=
26=E2=80=9D somewhere in its body, you=E2=80=99ll still get =E2=80=9C[AIRFL=
OW-426]=E2=80=9D in the squash commit subject.

https://issues.apache.org/jira/browse/AIRFLOW-426

AIRFLOW-427: You can now run the PR tool from anywhere (previously you had =
to be `cd`'d to the Airflow git repo or set an env var)

https://issues.apache.org/jira/browse/AIRFLOW-427

[AIRFLOW-423] Add reflow function to PR tool

The reflow function takes a string and wraps
it to a specified width. It preserves
paragraph breaks and 4+ space indentation.

[AIRFLOW-424] Make JIRA process more clear

Small improvements to UX around
closing JIRA issues.

Also a number of whitespace edits
to clean up the PR tool code.

[AIRFLOW-426] Automatically add JIRA references in PR Tool

When squashing commits, the PR tool will automatically add a reference
to any JIRA issue found in the PR body or commits.

[AIRFLOW-427] Automatically set AIRFLOW_GIT_LOCATION

Previously, you had to run this file from the airflow git
directory unless you set an AIRFLOW_GIT env var.

Closes #1728 from jlowin/pr-tool


> PR Tool should automatically add JIRA references if they appear anywhere =
in the PR
> -------------------------------------------------------------------------=
---------
>
>                 Key: AIRFLOW-426
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-426
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: PR tool
>            Reporter: Jeremiah Lowin
>            Assignee: Jeremiah Lowin
>            Priority: Minor
>
> Currently we rely on the PR author to put [AIRFLOW-XX] references in thei=
r commit subjects and title. We can do better. The PR tool should scan the =
entire PR (and its commits) for ANY JIRA references, and automatically add =
them to the subject of a squash commit. This should happen even if they are=
 improperly formatted.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)