Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 76288200B5C for ; Thu, 11 Aug 2016 20:12:31 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 71D00160A90; Thu, 11 Aug 2016 18:12:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 615F2160A94 for ; Thu, 11 Aug 2016 20:12:30 +0200 (CEST) Received: (qmail 61819 invoked by uid 500); 11 Aug 2016 18:12:29 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 61810 invoked by uid 99); 11 Aug 2016 18:12:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Aug 2016 18:12:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1A214C0269 for ; Thu, 11 Aug 2016 18:12:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.539 X-Spam-Level: X-Spam-Status: No, score=-4.539 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.519] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 6QrVili6HGis for ; Thu, 11 Aug 2016 18:12:27 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 1466B60D2B for ; Thu, 11 Aug 2016 18:12:25 +0000 (UTC) Received: (qmail 60366 invoked by uid 99); 11 Aug 2016 18:12:24 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Aug 2016 18:12:24 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 46E672C02B0 for ; Thu, 11 Aug 2016 18:12:23 +0000 (UTC) Date: Thu, 11 Aug 2016 18:12:23 +0000 (UTC) From: "Dan Davydov (JIRA)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (AIRFLOW-417) UI should not print traceback for missing dag/task in URL MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 11 Aug 2016 18:12:31 -0000 [ https://issues.apache.org/jira/browse/AIRFLOW-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Davydov updated AIRFLOW-417: -------------------------------- Component/s: webserver > UI should not print traceback for missing dag/task in URL > --------------------------------------------------------- > > Key: AIRFLOW-417 > URL: https://issues.apache.org/jira/browse/AIRFLOW-417 > Project: Apache Airflow > Issue Type: Bug > Components: webserver > Reporter: Dan Davydov > Labels: UI > > Right now if a user runs tries to do certain things in the UI with dags/tasks that don't exist they get confusing tracebacks rather than an error rendered in html like "the dag/task doesn't exist". One such traceback can be seen by going to the tree view for any DAG in the UI and then changing the url in the address bar for the dag_id to be a non-existent dag. The following traceback can be seen: > {quote} > Traceback (most recent call last): > File "/usr/local/lib/python2.7/dist-packages/Flask-0.10.1-py2.7.egg/flask/app.py", line 1817, in wsgi_app > response = self.full_dispatch_request() > File "/usr/local/lib/python2.7/dist-packages/Flask-0.10.1-py2.7.egg/flask/app.py", line 1477, in full_dispatch_request > rv = self.handle_user_exception(e) > File "/usr/local/lib/python2.7/dist-packages/Flask-0.10.1-py2.7.egg/flask/app.py", line 1381, in handle_user_exception > reraise(exc_type, exc_value, tb) > File "/usr/local/lib/python2.7/dist-packages/Flask-0.10.1-py2.7.egg/flask/app.py", line 1475, in full_dispatch_request > rv = self.dispatch_request() > File "/usr/local/lib/python2.7/dist-packages/Flask-0.10.1-py2.7.egg/flask/app.py", line 1461, in dispatch_request > return self.view_functions[rule.endpoint](**req.view_args) > File "/usr/local/lib/python2.7/dist-packages/Flask_Admin-1.4.0-py2.7.egg/flask_admin/base.py", line 68, in inner > return self._run_view(f, *args, **kwargs) > File "/usr/local/lib/python2.7/dist-packages/Flask_Admin-1.4.0-py2.7.egg/flask_admin/base.py", line 367, in _run_view > return fn(self, *args, **kwargs) > File "/usr/local/lib/python2.7/dist-packages/Flask_Login-0.2.11-py2.7.egg/flask_login.py", line 758, in decorated_view > return func(*args, **kwargs) > File "/usr/local/lib/python2.7/dist-packages/airflow/www/utils.py", line 213, in view_func > return f(*args, **kwargs) > File "/usr/local/lib/python2.7/dist-packages/airflow/www/utils.py", line 118, in wrapper > return f(*args, **kwargs) > File "/usr/local/lib/python2.7/dist-packages/airflow/www/views.py", line 1208, in tree > base_date = dag.latest_execution_date or datetime.now() > AttributeError: 'NoneType' object has no attribute 'latest_execution_date' > {quote} -- This message was sent by Atlassian JIRA (v6.3.4#6332)