Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 230DC200B59 for ; Mon, 8 Aug 2016 18:24:26 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 21682160AB3; Mon, 8 Aug 2016 16:24:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6818C160A77 for ; Mon, 8 Aug 2016 18:24:25 +0200 (CEST) Received: (qmail 40321 invoked by uid 500); 8 Aug 2016 16:24:24 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 40307 invoked by uid 99); 8 Aug 2016 16:24:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Aug 2016 16:24:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 17458181240 for ; Mon, 8 Aug 2016 16:24:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id arwzW77hG4DJ for ; Mon, 8 Aug 2016 16:24:22 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with SMTP id E8F665FAFE for ; Mon, 8 Aug 2016 16:24:21 +0000 (UTC) Received: (qmail 40184 invoked by uid 99); 8 Aug 2016 16:24:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Aug 2016 16:24:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id AE3EB2C0D63 for ; Mon, 8 Aug 2016 16:24:20 +0000 (UTC) Date: Mon, 8 Aug 2016 16:24:20 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AIRFLOW-399) Remove dags/testdruid.py MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 08 Aug 2016 16:24:26 -0000 [ https://issues.apache.org/jira/browse/AIRFLOW-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412034#comment-15412034 ] ASF subversion and git services commented on AIRFLOW-399: --------------------------------------------------------- Commit 62768bc087e95bf4506a8ec24d4291d7dfa7abaf in incubator-airflow's branch refs/heads/master from [~sanand] [ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=62768bc ] [AIRFLOW-399] - Remove dags/testdruid.py Remove the current example in dags/testdruid.py. It requires the installation of an extraneous library (Hive) and executes a query against table that no one has. In its place, I am creating a simple DAG that only depends on DummyOperator and standard Python packages. Dear Airflow Maintainers, Please accept this PR that addresses the following issues: - https://issues.apache.org/jira/browse/AIRFLOW-399 Testing Done: Manual. aoen criccomini artwr jlowin bolkedebruin Closes #1709 from r39132/master > Remove dags/testdruid.py > ------------------------ > > Key: AIRFLOW-399 > URL: https://issues.apache.org/jira/browse/AIRFLOW-399 > Project: Apache Airflow > Issue Type: Bug > Affects Versions: Airflow 1.7.1.3 > Reporter: Siddharth Anand > Assignee: Siddharth Anand > > Airflow ships with dags/testdruid,py, which is useless. It depends on a hive table that no-one (but the original committer who set up) has access to. Additionally, it depends on Hive, which is not a standard package that ships in the setup.py file. Finally, Hive is clearly not a requirement for using Airflow. > Looking over the commit that introduced this, it seems like the committer made a mistake by committing it -- he used it for his own testing. And, no one corrected this! > I'm deleting it and adding a simple example dag in its place with no extraneous dependencies -- This message was sent by Atlassian JIRA (v6.3.4#6332)