airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-426) PR Tool should automatically add JIRA references if they appear anywhere in the PR
Date Sun, 14 Aug 2016 02:40:21 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420178#comment-15420178
] 

ASF subversion and git services commented on AIRFLOW-426:
---------------------------------------------------------

Commit 3767e69dd0ed6d6ea245da87b2b6297e5140cd76 in incubator-airflow's branch refs/heads/master
from jlowin
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=3767e69 ]

[AIRFLOW-423][AIRFLOW-424][AIRFLOW-426] UX updates for PR Tool

Some big UX improvements to the PR tool:

AIRFLOW-423: commit messages are automatically wrapped at 50 characters. Paragraph breaks
and tab indents are preserved. The first line of the commit is NOT forced to be 72 characters
because handling this on subsequent lines is challenging. This is also deployed throughout
the PR tool to make long status messages prettier.

https://issues.apache.org/jira/browse/AIRFLOW-423

AIRFLOW-424: this commit fixes a number of whitespace and formatting issues. It’s only contribution
to functionality is that the JIRA resolution process is a little clearer.

https://issues.apache.org/jira/browse/AIRFLOW-424

AIRFLOW-426: I think this one is pretty cool. If the PR author mentions a JIRA issue anywhere
in their PR (including on GitHub or buried in a commit), then the PR tool will automatically
add it to the PR title. It even catches misformatted ones. So if the 20th commit mentions
“AIRFLOW   - -426” somewhere in its body, you’ll still get “[AIRFLOW-426]” in the
squash commit subject.

https://issues.apache.org/jira/browse/AIRFLOW-426

AIRFLOW-427: You can now run the PR tool from anywhere (previously you had to be `cd`'d to
the Airflow git repo or set an env var)

https://issues.apache.org/jira/browse/AIRFLOW-427

[AIRFLOW-423] Add reflow function to PR tool

The reflow function takes a string and wraps
it to a specified width. It preserves
paragraph breaks and 4+ space indentation.

[AIRFLOW-424] Make JIRA process more clear

Small improvements to UX around
closing JIRA issues.

Also a number of whitespace edits
to clean up the PR tool code.

[AIRFLOW-426] Automatically add JIRA references in PR Tool

When squashing commits, the PR tool will automatically add a reference
to any JIRA issue found in the PR body or commits.

[AIRFLOW-427] Automatically set AIRFLOW_GIT_LOCATION

Previously, you had to run this file from the airflow git
directory unless you set an AIRFLOW_GIT env var.

Closes #1728 from jlowin/pr-tool


> PR Tool should automatically add JIRA references if they appear anywhere in the PR
> ----------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-426
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-426
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: PR tool
>            Reporter: Jeremiah Lowin
>            Assignee: Jeremiah Lowin
>            Priority: Minor
>
> Currently we rely on the PR author to put [AIRFLOW-XX] references in their commit subjects
and title. We can do better. The PR tool should scan the entire PR (and its commits) for ANY
JIRA references, and automatically add them to the subject of a squash commit. This should
happen even if they are improperly formatted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message