airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael DeWulf (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-409) Add option to not configure logging (keep existing loggers)
Date Sat, 20 Aug 2016 14:50:20 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429403#comment-15429403
] 

Michael DeWulf commented on AIRFLOW-409:
----------------------------------------

PR: https://github.com/apache/incubator-airflow/pull/1745

Doesn't have a new do-not-configure option, but instead avoids modifying the root logger as
mentioned in the previous comment.

> Add option to not configure logging (keep existing loggers)
> -----------------------------------------------------------
>
>                 Key: AIRFLOW-409
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-409
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: logging
>            Reporter: Michael DeWulf
>            Assignee: Michael DeWulf
>            Priority: Minor
>
> The airflow.settings module calls [configure_logging|https://github.com/apache/incubator-airflow/blob/b18c9959142f3f1e2cb031c8709225af01192e32/airflow/settings.py#L127],
which removes all existing loggers and installs the basic logging config.  For projects with
loggers already configured, it would be nice if this could be disabled.
> It seems like we could add a config option which is checked before logging is configured
by airflow.  If the option is false, then logging would not be configured.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message