Return-Path: <commits-return-2598-archive-asf-public=cust-asf.ponee.io@airflow.incubator.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 6CB6E200B4F
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue, 26 Jul 2016 19:31:27 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 6B644160A69; Tue, 26 Jul 2016 17:31:27 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id B4794160A75
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 26 Jul 2016 19:31:26 +0200 (CEST)
Received: (qmail 83172 invoked by uid 500); 26 Jul 2016 17:31:26 -0000
Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@airflow.incubator.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@airflow.incubator.apache.org>
List-Post: <mailto:commits@airflow.incubator.apache.org>
List-Id: <commits.airflow.incubator.apache.org>
Reply-To: dev@airflow.incubator.apache.org
Delivered-To: mailing list commits@airflow.incubator.apache.org
Received: (qmail 83163 invoked by uid 99); 26 Jul 2016 17:31:25 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jul 2016 17:31:25 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 6B464C2399
	for <commits@airflow.apache.org>; Tue, 26 Jul 2016 17:31:25 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -5.307
X-Spam-Level: 
X-Spam-Status: No, score=-5.307 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-1.287] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024)
	with ESMTP id 4JefGFxOX-aR for <commits@airflow.apache.org>;
	Tue, 26 Jul 2016 17:31:23 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 0B6B460D2C
	for <commits@airflow.incubator.apache.org>; Tue, 26 Jul 2016 17:31:21 +0000 (UTC)
Received: (qmail 82536 invoked by uid 99); 26 Jul 2016 17:31:21 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jul 2016 17:31:21 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id DC62F2C0D5D
	for <commits@airflow.incubator.apache.org>; Tue, 26 Jul 2016 17:31:20 +0000 (UTC)
Date: Tue, 26 Jul 2016 17:31:20 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: commits@airflow.incubator.apache.org
Message-ID: <JIRA.12991661.1469145217000.136596.1469554280899@Atlassian.JIRA>
In-Reply-To: <JIRA.12991661.1469145217000@Atlassian.JIRA>
References: <JIRA.12991661.1469145217000@Atlassian.JIRA> <JIRA.12991661.1469145217353@arcas>
Subject: [jira] [Commented] (AIRFLOW-356) <nobr> is used on the front page
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Tue, 26 Jul 2016 17:31:27 -0000


    [ https://issues.apache.org/jira/browse/AIRFLOW-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394143#comment-15394143 ] 

ASF subversion and git services commented on AIRFLOW-356:
---------------------------------------------------------

Commit a89d1015ceb6abccd53572bf38a44544d0182ca9 in incubator-airflow's branch refs/heads/master from [~xuanji]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=a89d101 ]

[AIRFLOW-356][AIRFLOW-355][AIRFLOW-354] Replace nobr, enable DAG only exists locally message, change edit DAG icon

Addresses the following issues:
- [https://issues.apache.org/jira/browse/AIRFLOW-356](https://issues.apache.org/jira/browse/AIRFLOW-356)
- [https://issues.apache.org/jira/browse/AIRFLOW-355](https://issues.apache.org/jira/browse/AIRFLOW-355)
- [https://issues.apache.org/jira/browse/AIRFLOW-354](https://issues.apache.org/jira/browse/AIRFLOW-354)

- Replace `<nobr>` with `flexbox`
- "This DAG seems to be existing only locally" now shows up
- Change edit DAG icon from info to edit
- Rename `dttm` variable to `file_last_changed_on_disk`
- Rename `dags` variable to `webserver_dags`
- Adds a comment clarifying what `self.file_last_changed` is
- Clarifies what the `dag.last_expired` column represents
- Refactors some previously very nested logic in `views.py` and adds comments
- Properly indents `dags.html` and adds comments to it

- Edit DAG icon changed
- Home page now sort of responsive, no longer fixed width
- User will occasionally see "This DAG seems to be existing only locally" message

- Verify that edit dag button is now an edit icon and click on it
- Resized home page, check that last column does not wrap

![image](https://cloud.githubusercontent.com/assets/130362/17126889/2e7adb12-52b6-11e6-9a18-b31e424e4be8.png)

Clean up html, replace nobr with flexbox

Refactor HomeView

Rename variables and update comments

Closes #1678 from zodiac/xuanji_refactor


> <nobr> is used on the front page
> --------------------------------
>
>                 Key: AIRFLOW-356
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-356
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Li Xuanji
>            Assignee: Li Xuanji
>            Priority: Trivial
>
> The <nobr> tag, which is non-standard and not on a standards track (per https://developer.mozilla.org/en-US/docs/Web/HTML/Element/nobr), is used on the front admin page. Alternatives like flexbox can be used instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)