airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-355) "Dag only exists locally" message is never displayed
Date Tue, 26 Jul 2016 17:31:20 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394146#comment-15394146
] 

ASF subversion and git services commented on AIRFLOW-355:
---------------------------------------------------------

Commit a89d1015ceb6abccd53572bf38a44544d0182ca9 in incubator-airflow's branch refs/heads/master
from [~xuanji]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=a89d101 ]

[AIRFLOW-356][AIRFLOW-355][AIRFLOW-354] Replace nobr, enable DAG only exists locally message,
change edit DAG icon

Addresses the following issues:
- [https://issues.apache.org/jira/browse/AIRFLOW-356](https://issues.apache.org/jira/browse/AIRFLOW-356)
- [https://issues.apache.org/jira/browse/AIRFLOW-355](https://issues.apache.org/jira/browse/AIRFLOW-355)
- [https://issues.apache.org/jira/browse/AIRFLOW-354](https://issues.apache.org/jira/browse/AIRFLOW-354)

- Replace `<nobr>` with `flexbox`
- "This DAG seems to be existing only locally" now shows up
- Change edit DAG icon from info to edit
- Rename `dttm` variable to `file_last_changed_on_disk`
- Rename `dags` variable to `webserver_dags`
- Adds a comment clarifying what `self.file_last_changed` is
- Clarifies what the `dag.last_expired` column represents
- Refactors some previously very nested logic in `views.py` and adds comments
- Properly indents `dags.html` and adds comments to it

- Edit DAG icon changed
- Home page now sort of responsive, no longer fixed width
- User will occasionally see "This DAG seems to be existing only locally" message

- Verify that edit dag button is now an edit icon and click on it
- Resized home page, check that last column does not wrap

![image](https://cloud.githubusercontent.com/assets/130362/17126889/2e7adb12-52b6-11e6-9a18-b31e424e4be8.png)

Clean up html, replace nobr with flexbox

Refactor HomeView

Rename variables and update comments

Closes #1678 from zodiac/xuanji_refactor


> "Dag only exists locally" message is never displayed
> ----------------------------------------------------
>
>                 Key: AIRFLOW-355
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-355
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Li Xuanji
>            Assignee: Li Xuanji
>            Priority: Trivial
>
> Because of the `and False` here https://github.com/apache/incubator-airflow/blob/master/airflow/www/templates/airflow/dags.html#L72,
the message is never displayed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message