airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (AIRFLOW-354) info-sign glyphicon is used for edit dag button -
Date Tue, 26 Jul 2016 17:31:20 GMT


ASF subversion and git services commented on AIRFLOW-354:

Commit a89d1015ceb6abccd53572bf38a44544d0182ca9 in incubator-airflow's branch refs/heads/master
from [~xuanji]
[;h=a89d101 ]

[AIRFLOW-356][AIRFLOW-355][AIRFLOW-354] Replace nobr, enable DAG only exists locally message,
change edit DAG icon

Addresses the following issues:
- [](
- [](
- [](

- Replace `<nobr>` with `flexbox`
- "This DAG seems to be existing only locally" now shows up
- Change edit DAG icon from info to edit
- Rename `dttm` variable to `file_last_changed_on_disk`
- Rename `dags` variable to `webserver_dags`
- Adds a comment clarifying what `self.file_last_changed` is
- Clarifies what the `dag.last_expired` column represents
- Refactors some previously very nested logic in `` and adds comments
- Properly indents `dags.html` and adds comments to it

- Edit DAG icon changed
- Home page now sort of responsive, no longer fixed width
- User will occasionally see "This DAG seems to be existing only locally" message

- Verify that edit dag button is now an edit icon and click on it
- Resized home page, check that last column does not wrap


Clean up html, replace nobr with flexbox

Refactor HomeView

Rename variables and update comments

Closes #1678 from zodiac/xuanji_refactor

> info-sign glyphicon is used for edit dag button - 
> --------------------------------------------------
>                 Key: AIRFLOW-354
>                 URL:
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Li Xuanji
>            Assignee: Li Xuanji
>            Priority: Trivial
> The info-sign glyphicon is used for the edit dag button (leftmost column on the front
page). The edit glyphicon should be used instead.

This message was sent by Atlassian JIRA

View raw message