airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kengo Seki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-307) Code cleanup. There is no __neq__ python magic method.
Date Mon, 04 Jul 2016 02:30:11 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360757#comment-15360757
] 

Kengo Seki commented on AIRFLOW-307:
------------------------------------

Hi [~ozawa], it seems [~o.vilchynskyy@ukr.net] has already submitted a PR. https://github.com/apache/incubator-airflow/pull/1645
Maybe reassign to him?

> Code cleanup. There is no __neq__ python magic method.
> ------------------------------------------------------
>
>                 Key: AIRFLOW-307
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-307
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: operators
>    Affects Versions: Airflow 1.8, Airflow 1.7.1, Airflow 1.7.1.3
>            Reporter: Oleksandr Vilchynskyy
>            Assignee: Tsuyoshi Ozawa
>            Priority: Minor
>
> There is small mistype in  class BaseOperator(object)  which is decorated with functools.total_ordering:
> def __neq__    was used instead of __ne__, which breaks logic of later objects comparison.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message