airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-302) The Bolke Correction: take squash commit messages from individual commit messages
Date Tue, 12 Jul 2016 14:56:21 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372995#comment-15372995
] 

ASF subversion and git services commented on AIRFLOW-302:
---------------------------------------------------------

Commit f3a05d4733acb2634ab49fa6bc1d83cf55289569 in incubator-airflow's branch refs/heads/master
from jlowin
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=f3a05d4 ]

[AIRFLOW-302] Improve default squash commit message

Previously, we always used the PR title as the squash commit subject.
Now, if the squash contains only one commit, then we use the commit
message for the squash commit message. If the squash contains more than
one commit, we default to the old behavior (using the PR title). We
still ask if the user wants to include the PR body, but we only ask if
they want to include the individual commits if there was more than one.


> The Bolke Correction: take squash commit messages from individual commit messages
> ---------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-302
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-302
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: PR tool
>            Reporter: Jeremiah Lowin
>            Assignee: Jeremiah Lowin
>
> Currently, squash commit subjects are taken from the PR title (which should reference
all JIRA issues). However this can be redundant in the case where there is just one commit,
since it will be in the PR title and the commit message. Add an option (possibly default,
or maybe default when there is only one referenced issue or one commit) to use the first commit
message as the squash commit message.
> cc [~bolke] for suggesting it



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message