airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-281) mssql_hook does not pass port to pymssql's connection method.
Date Tue, 28 Jun 2016 22:17:57 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353800#comment-15353800
] 

ASF subversion and git services commented on AIRFLOW-281:
---------------------------------------------------------

Commit be6766a6a87f7b131c0cbe404c0ce45dbaed0cd7 in incubator-airflow's branch refs/heads/master
from [~lukem]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=be6766a ]

[AIRFLOW-281] Add port to mssql_hook

Closes #1626 from lukem-ow/master


> mssql_hook does not pass port to pymssql's connection method. 
> --------------------------------------------------------------
>
>                 Key: AIRFLOW-281
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-281
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: hooks
>            Reporter: Luke Maycock
>            Assignee: Luke Maycock
>             Fix For: Airflow 1.8
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> The mssql_hook does not pass the port through to pymssql's connection method. Therefore,
the port entered in the UI in 'Admin > Connections' is ignored for mssql connections. 
> Proposed fix: 
> Used named arguments and include the 'port' argument. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message