airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-180) Sensors do not test timeout correctly if timeout is more than a day/
Date Mon, 20 Jun 2016 23:02:57 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15340621#comment-15340621
] 

ASF subversion and git services commented on AIRFLOW-180:
---------------------------------------------------------

Commit c38a5c2a8b227194ec52d81e8a5a85c97751ecd9 in incubator-airflow's branch refs/heads/master
from [~artwr]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=c38a5c2 ]

[AIRFLOW-180] Fix timeout behavior for sensors

In the previous state of the code, datetime.now was compared to
started_at and seconds was pulled out. It turns out that the seconds
attribute of a timedelta has a maximum of 86400 and the rolls up to 1 day.
The unintended consequence is that timeout larger than 86400 are
ignored, with sensors running forever.

To fix this we use the total_seconds method to get at the real
timedelta in seconds.


> Sensors do not test timeout correctly if timeout is more than a day/
> --------------------------------------------------------------------
>
>                 Key: AIRFLOW-180
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-180
>             Project: Apache Airflow
>          Issue Type: Bug
>    Affects Versions: Airflow 1.7.1, Airflow 1.7.0, Airflow 1.6.2, Airflow 1.7.1.2
>            Reporter: Arthur Wiedmer
>            Assignee: Arthur Wiedmer
>              Labels: sensors
>             Fix For: Airflow 1.8
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Currently the sensors tests the timedelta seconds, instead of the timedelta total_seconds



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message