Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 475FC2007D0 for ; Tue, 10 May 2016 19:32:17 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 450C916098A; Tue, 10 May 2016 17:32:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8D5F2160877 for ; Tue, 10 May 2016 19:32:16 +0200 (CEST) Received: (qmail 18693 invoked by uid 500); 10 May 2016 17:32:15 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 18684 invoked by uid 99); 10 May 2016 17:32:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 May 2016 17:32:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 52F58CB9D3 for ; Tue, 10 May 2016 17:32:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.299 X-Spam-Level: X-Spam-Status: No, score=-5.299 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.079] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id KWDvjQvYKyas for ; Tue, 10 May 2016 17:32:14 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id D4FBB60CEF for ; Tue, 10 May 2016 17:32:13 +0000 (UTC) Received: (qmail 18678 invoked by uid 99); 10 May 2016 17:32:12 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 May 2016 17:32:12 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C72842C033A for ; Tue, 10 May 2016 17:32:12 +0000 (UTC) Date: Tue, 10 May 2016 17:32:12 +0000 (UTC) From: "Chris Riccomini (JIRA)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AIRFLOW-94) 'Mark upstream tasks as successful' does not actually select upstream tasks MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 10 May 2016 17:32:17 -0000 [ https://issues.apache.org/jira/browse/AIRFLOW-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278522#comment-15278522 ] Chris Riccomini commented on AIRFLOW-94: ---------------------------------------- Hmm. I'm not able to reproduce this. I'm attaching screenshots to illustrate what I did. Find a DAG run that has a failed task, and a failed downstream task: !1.png! Click the downstream task (that has upstream_failed_ as its state). !2.png! Click {{Upstream}}, and click mark success: !3.png! I see: Both the failed task (which is upstream of the one I clicked), and the task that I clicked: !4.png! > 'Mark upstream tasks as successful' does not actually select upstream tasks > --------------------------------------------------------------------------- > > Key: AIRFLOW-94 > URL: https://issues.apache.org/jira/browse/AIRFLOW-94 > Project: Apache Airflow > Issue Type: Bug > Environment: EC2 t2.medium instance, > Docker `version 1.11.1, build 5604cbe`, > Host is `Linux ip-172-31-44-140 3.13.0-85-generic #129-Ubuntu SMP Thu Mar 17 20:50:15 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux`, > Docker containers are built upon the `python:3.5` image, > LocalExecutor is used with two scheduler containers running, > Airflow @ dddfd3b5bf2cabaac6eec123dfa3cb59e73a56f5 > Reporter: Bence Nagy > Attachments: 1.png, 2.png, 3.png, 4.png > > > Steps to reproduce: > 1. Add any DAG with a task depending on another > 2. Go to the web UI's tree view > 3. Click the depending task's latest execution (make sure the upstream task is not successful yet) > 4. Click the 'Upstream' button next 'Mark Success', then click 'Mark Success' > Only the depending task will be selected, its dependencies will not be there. -- This message was sent by Atlassian JIRA (v6.3.4#6332)