airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-109) PrestoHook get_pandas_df executes a method that can raise outside of the try catch statement.
Date Mon, 16 May 2016 21:19:13 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285327#comment-15285327
] 

ASF subversion and git services commented on AIRFLOW-109:
---------------------------------------------------------

Commit 6f4696ba2ef18d74be8c18080b8ea7b9419608fb in incubator-airflow's branch refs/heads/master
from [~artwr]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=6f4696b ]

[AIRFLOW-109] Fix try catch handling in PrestoHook

This addresses the issue with executing the SQL statement outside of
the try block. In the case of a syntax error in the statement, the
underlying library raises a Databases error which was meant to be
handled (i.e., json parsed) by the catch.


> PrestoHook get_pandas_df executes a method that can raise outside of the try catch statement.
> ---------------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-109
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-109
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: hooks
>    Affects Versions: Airflow 1.8, Airflow 1.7.1, Airflow 1.6.2
>            Reporter: Arthur Wiedmer
>            Assignee: Arthur Wiedmer
>            Priority: Minor
>              Labels: Presto
>
> This issue occurs when a malformed SQL statement is passed to the get_pandas_df method
of the presto hook. Pyhive raises a DatabaseError outside of the try catch, leading in the
wrong kind of error being raised.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message