Return-Path: X-Original-To: apmail-airflow-commits-archive@minotaur.apache.org Delivered-To: apmail-airflow-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D04F419E0F for ; Fri, 29 Apr 2016 19:58:17 +0000 (UTC) Received: (qmail 28514 invoked by uid 500); 29 Apr 2016 19:58:17 -0000 Delivered-To: apmail-airflow-commits-archive@airflow.apache.org Received: (qmail 28487 invoked by uid 500); 29 Apr 2016 19:58:17 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 28478 invoked by uid 99); 29 Apr 2016 19:58:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Apr 2016 19:58:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id CAFE91A46D1 for ; Fri, 29 Apr 2016 19:58:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 1G2fbuITf89z for ; Fri, 29 Apr 2016 19:58:14 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id D73AA5F39B for ; Fri, 29 Apr 2016 19:58:13 +0000 (UTC) Received: (qmail 27850 invoked by uid 99); 29 Apr 2016 19:58:12 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Apr 2016 19:58:12 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D2C502C1F54 for ; Fri, 29 Apr 2016 19:58:12 +0000 (UTC) Date: Fri, 29 Apr 2016 19:58:12 +0000 (UTC) From: "Chris Riccomini (JIRA)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AIRFLOW-16) Use GCP-specific fields in hook view MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AIRFLOW-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264635#comment-15264635 ] Chris Riccomini commented on AIRFLOW-16: ---------------------------------------- For reference, after this is merged, I plan to cherry-pick it into our internal branch, and run it in all environments. It will be heavily exercised there, and I'll fix any bugs that emerge. Still, I think having you two test locally is very helpful. > Use GCP-specific fields in hook view > ------------------------------------ > > Key: AIRFLOW-16 > URL: https://issues.apache.org/jira/browse/AIRFLOW-16 > Project: Apache Airflow > Issue Type: Improvement > Reporter: Chris Riccomini > Labels: gcp > > Once AIRFLOW-15 is done, we should update the Google cloud base hook to use fields for project, service account, etc. We currently just use a JSON blob in the {{extras}} field. We can steal this code from [this|https://github.com/airbnb/airflow/pull/1119/files] PR, where {{extras\_\_google_cloud_platform_*}} is introduced in views.py. > We should also look at creating just one hook of type google_cloud_platform, rather than one hook per Google cloud service. Again, this is how the PR (above) works, and it's pretty handy. -- This message was sent by Atlassian JIRA (v6.3.4#6332)