From issues-return-17546-archive-asf-public=cust-asf.ponee.io@airavata.apache.org Mon Apr 27 21:59:06 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id ABBF818066D for ; Mon, 27 Apr 2020 23:59:05 +0200 (CEST) Received: (qmail 55311 invoked by uid 500); 27 Apr 2020 21:59:05 -0000 Mailing-List: contact issues-help@airavata.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@airavata.apache.org Received: (qmail 55302 invoked by uid 99); 27 Apr 2020 21:59:05 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Apr 2020 21:59:05 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 87F1FE103B for ; Mon, 27 Apr 2020 21:59:04 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id B872E780C3A for ; Mon, 27 Apr 2020 21:59:00 +0000 (UTC) Date: Mon, 27 Apr 2020 21:59:00 +0000 (UTC) From: "ASF subversion and git services (Jira)" To: issues@airavata.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AIRAVATA-3126) Implement compute resource reservation addition MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AIRAVATA-3126?page=3Dcom.atlass= ian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1= 7093964#comment-17093964 ]=20 ASF subversion and git services commented on AIRAVATA-3126: ----------------------------------------------------------- Commit bb8609673b8e2e21d2ec638613c4f319da1fb4e1 in airavata's branch refs/h= eads/master from Marcus Christie [ https://gitbox.apache.org/repos/asf?p=3Dairavata.git;h=3Dbb86096 ] Merge branch 'AIRAVATA-3126--Implement-compute-resource-reservation-additio= n' > Implement compute resource reservation addition=20 > ------------------------------------------------ > > Key: AIRAVATA-3126 > URL: https://issues.apache.org/jira/browse/AIRAVATA-3126 > Project: Airavata > Issue Type: Sub-task > Components: Django Portal, Registry API > Affects Versions: 0.18 > Environment: https://django.staging.seagrid.org > Reporter: Eroma > Assignee: Marcus Christie > Priority: Minor > > # In PGA portal implementation for a compute resource we could add a rese= rvation > # Reservation is to have a dedicate computing time in a cluster queue/pa= rtition > # As for the existing PGA implementation we could provide a reservation = name and a start and end time for the particular reservation.=C2=A0 > # In Django the implementation does not exists. > # First we should have the previous implementation done in Django portal > # Next step would be to improve it by enabling > # Adding a reservation for a particular cluster queue/partition > # Then we should also be able to add multiple reservations for a particu= lar queue/partition. These multiples will have different reservation names = and start and end dates. > h5. Data Model > - GroupComputeResourcePreference > -- reservations: list > --- queues: list > --- reservationName > --- startTime > --- endTime > A GroupComputeResourcePreference can have one or more ComputeResourceRese= rvation records. Each ComputeResourceReservation is applicable to one or mo= re queue/partitions for the GroupComputeResourcePreference's compute host. = The ComputeResourceReservation also has a name, start date and end date. > h5. TODO > - [x] how to deal with expired reservations? > -- in the UI have a button to remove all expired reservations > - [ ] Validation: don't allow multiple reservations for the same queue/p= artition for the same overlapping time period? > - [x] Validation: endTime must be greater than startTime > - [x] update TaskContext.getReservation() logic where it looks to see if= there is a currrently active reservation for the host and queue > - [ ] document the automatic migration script creation logic -> moved to= AIRAVATA-3326 > - [x] Repository unit test: removing a reservation > - [x] Repository unit test: updating a reservation > - [x] Repository unit test: adding a queue > - [x] Repository unit test: removing a queue > - [x] Refactor the openjpa MappingTool migration script creation logic > - [ ] remove generate-sql-persistence.xml and maven goal that used it ->= moved to AIRAVATA-3326 > - [x] migration for GroupComputeResourcePreference.reservation/reservati= onStartTime/reservationEndTime into a ComputeResourceReservation record > -- since there was no UI for creating these, we don't have any of these = records. So we really don't need to bother with this migration. > - [ ] switch ide-integration to using mariadb instead of mysqld for bett= er compatibility with migration scripts -> moved to AIRAVATA-3326 > - [ ] if not switching to mariadb then we need to remove IF NOT EXISTS f= rom the migration script > - [x] summarize active (and upcoming?) reservations on Group Resource Pr= ofile view > - [x] invalidate GroupComputeResourcePreference save when reservation is= invalid > - [x] fix GroupComputeResourcePreference save/delete/cancel buttons to b= ottom of viewport=20 > - [x] reservations move around in the UI when date based sort changes, m= aybe don't dynamically sort > - [x] minutes aren't getting set if not selected? Can they be defaulted = to 00? Might also need to zero out seconds. > - [ ] inline form for the reservation editor? > - [x] don't allow picking an end date before the start date > - [x] test using the {{drop}} action to see if a migration can be genera= ted when columns/tables are removed: http://openjpa.apache.org/builds/3.1.0= /apache-openjpa/docs/ref_guide_mapping.html#ref_guide_mapping_mappingtool_t= ypical > -- this doesn't really work because the migration generation only runs a= fter validation fails. And validation only fails on when mapped columns are= missing in the database. > h5. Migration Plan > h6. Expand > - database migration to add new tables > - -convert GroupComputeResourcePreference.reservation/reservationStartTi= me/reservationEndTime into a ComputeResourceReservation record- > -- since there was no UI for creating GroupComputeResourcePreference.res= ervation, we don't have any of these records. So we really don't need to bo= ther with this migration. > - -trigger to turn new values in GroupComputeResourcePreference.reservat= ionName/reservationStartTime/reservationEndTime into ComputeResourceReserva= tion records- > -- likewise > - but I don't think there is any UI or anything updating these fields no= w > - deploy API server with new ComputeResourceReservation model > h6. Migrate > - Deploy Django UI for managing ComputeResourceReservation records > - Helix tasks should check the ComputeResourceReservation records in add= ition to GroupComputeResourcePreference.reservationName/reservationStartTim= e/reservationEndTime > h6. Contract > - Helix tasks should stop checking the GroupComputeResourcePreference.re= servationName/reservationStartTime/reservationEndTime > - Remove data model fields GroupComputeResourcePreference.reservation/re= servationStartTime/reservationEndTime and entity mappings > - remove database columns -- This message was sent by Atlassian Jira (v8.3.4#803005)